Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Zipkin Receiver to include Protocols in Config #35730

Open
EOjeah opened this issue Oct 10, 2024 · 6 comments · May be fixed by #35851
Open

Refactor Zipkin Receiver to include Protocols in Config #35730

EOjeah opened this issue Oct 10, 2024 · 6 comments · May be fixed by #35851
Assignees
Labels
enhancement New feature or request receiver/zipkin Zipkin receiver Stale

Comments

@EOjeah
Copy link
Contributor

EOjeah commented Oct 10, 2024

Component(s)

receiver/zipkin

Is your feature request related to a problem? Please describe.

Feature Request
Refactor zipkin receiver to include protocols in configuration
Current

zipkin:

After

zipkin:
  protocols:
    http:

Describe the solution you'd like

In order to prepare the zipkin receiver for potentially adding a udp receiver as specified in #35620 and reduce the amount of changes associated with one issue.
This issue is to refactor the code to accept zipkin configuration with potentially different protocols. Initially accepted is the current http protocol with this change.
This will match more closely with the configuration in the otlp receiver that accepts both http and grpc
Before

zipkin:

After

zipkin:
  protocols:
    http:

Follow up changes to include udp protocol in another change.

Describe alternatives you've considered

No response

Additional context

Related to #35620

@EOjeah EOjeah added enhancement New feature or request needs triage New item requiring triage labels Oct 10, 2024
@github-actions github-actions bot added the receiver/zipkin Zipkin receiver label Oct 10, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@andrzej-stencel andrzej-stencel removed the needs triage New item requiring triage label Oct 11, 2024
@andrzej-stencel
Copy link
Member

Given that the Zipkin receiver is one of the oldest components and has been in Beta stability for a long time, I wonder if we can introduce support for UDP without a breaking change?

One approach could be to leave the existing top-level options like endpoint and other HTTP config options unchanged and still supported (possibly deprecated), and use those unless the user provides the protocols option.

@odubajDT
Copy link
Contributor

I like the idea, if possible I would like to work on this issue, also including the upd support if @EOjeah is not working on it already

@EOjeah
Copy link
Contributor Author

EOjeah commented Oct 14, 2024

@odubajDT go ahead! I was planning on working on this when I have time in the next few weeks since it's not urgent for me right now.

@andrzej-stencel
Copy link
Member

The issue is yours @odubajDT 🚀

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request receiver/zipkin Zipkin receiver Stale
Projects
None yet
3 participants