-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Zipkin Receiver to include Protocols in Config #35730
Comments
Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Given that the Zipkin receiver is one of the oldest components and has been in Beta stability for a long time, I wonder if we can introduce support for UDP without a breaking change? One approach could be to leave the existing top-level options like |
I like the idea, if possible I would like to work on this issue, also including the upd support if @EOjeah is not working on it already |
@odubajDT go ahead! I was planning on working on this when I have time in the next few weeks since it's not urgent for me right now. |
The issue is yours @odubajDT 🚀 |
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping Pinging code owners:
See Adding Labels via Comments if you do not have permissions to add labels yourself. |
Component(s)
receiver/zipkin
Is your feature request related to a problem? Please describe.
Feature Request
Refactor zipkin receiver to include
protocols
in configurationCurrent
zipkin:
After
Describe the solution you'd like
In order to prepare the zipkin receiver for potentially adding a
udp
receiver as specified in #35620 and reduce the amount of changes associated with one issue.This issue is to refactor the code to accept zipkin configuration with potentially different protocols. Initially accepted is the current
http
protocol with this change.This will match more closely with the configuration in the
otlp
receiver that accepts bothhttp
andgrpc
Before
zipkin:
After
Follow up changes to include
udp
protocol in another change.Describe alternatives you've considered
No response
Additional context
Related to #35620
The text was updated successfully, but these errors were encountered: