You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
At the moment extension/db_storage is using github.com/mattn/go-sqlite3 driver which require CGO_ENABLED=1 during build time to work.
But, according Contribution Guide using CGO is prohibited and it's make sense to replace github.com/mattn/go-sqlite3 driver with pure Go driver to eliminate CGO_ENABLED=1 requirement.
Fortunately, there is few pure Go drivers that might be used as drop-in replacement (thanks Grafana developers for initial evaluation):
modernc.org/sqlite
github.com/glebarez/go-sqlite
github.com/ncruces/go-sqlite3
Because of nature how SQLite driver is used in extension/db_storage this change shouldn't introduce any major issues from my perspective
The text was updated successfully, but these errors were encountered:
This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.
Component(s)
extension/storage/dbstorage
Describe the issue you're reporting
At the moment
extension/db_storage
is using github.com/mattn/go-sqlite3 driver which requireCGO_ENABLED=1
during build time to work.But, according Contribution Guide using CGO is prohibited and it's make sense to replace github.com/mattn/go-sqlite3 driver with pure Go driver to eliminate
CGO_ENABLED=1
requirement.Fortunately, there is few pure Go drivers that might be used as drop-in replacement (thanks Grafana developers for initial evaluation):
Because of nature how SQLite driver is used in
extension/db_storage
this change shouldn't introduce any major issues from my perspectiveThe text was updated successfully, but these errors were encountered: