Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[extension/db_storage] Replace github.com/mattn/go-sqlite3 with a non-CGO alternative #35280

Open
Fiery-Fenix opened this issue Sep 18, 2024 · 4 comments
Assignees

Comments

@Fiery-Fenix
Copy link
Contributor

Component(s)

extension/storage/dbstorage

Describe the issue you're reporting

At the moment extension/db_storage is using github.com/mattn/go-sqlite3 driver which require CGO_ENABLED=1 during build time to work.
But, according Contribution Guide using CGO is prohibited and it's make sense to replace github.com/mattn/go-sqlite3 driver with pure Go driver to eliminate CGO_ENABLED=1 requirement.
Fortunately, there is few pure Go drivers that might be used as drop-in replacement (thanks Grafana developers for initial evaluation):

  • modernc.org/sqlite
  • github.com/glebarez/go-sqlite
  • github.com/ncruces/go-sqlite3

Because of nature how SQLite driver is used in extension/db_storage this change shouldn't introduce any major issues from my perspective

@Fiery-Fenix Fiery-Fenix added the needs triage New item requiring triage label Sep 18, 2024
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@atoulme atoulme removed the needs triage New item requiring triage label Oct 2, 2024
@atoulme
Copy link
Contributor

atoulme commented Oct 2, 2024

Sounds good. Would you like to offer a PR?

@thiha-min-thant
Copy link

Hi @atoulme , could you please assign to me? Thanks!

Copy link
Contributor

github-actions bot commented Jan 8, 2025

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants