Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicitly define processors that drop the client context #34453

Closed
dmitryax opened this issue Aug 6, 2024 · 3 comments
Closed

Explicitly define processors that drop the client context #34453

dmitryax opened this issue Aug 6, 2024 · 3 comments
Labels
closed as inactive documentation Improvements or additions to documentation help wanted Extra attention is needed Stale

Comments

@dmitryax
Copy link
Member

dmitryax commented Aug 6, 2024

We have a few processors that drop client metadata (context), which potentially can carry important authentication data that exporters are supposed to use.

It's important to clearly document the processors dropping the context. Can be done in metadata.yaml as another warning added to https://github.com/open-telemetry/opentelemetry-collector/blob/main/docs/standard-warnings.md#unsound-transformations.

Action items

  1. Identify processors dropping the context
  2. Fix those that drop it unintentionally
  3. Document those that drop it intentionally
@dmitryax dmitryax added documentation Improvements or additions to documentation help wanted Extra attention is needed labels Aug 6, 2024
@Neema-Joju
Copy link

Neema-Joju commented Aug 12, 2024

Hi,
May I work on this issue?
It would be my first time contributing to this repo.
Thanks

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

@github-actions github-actions bot added the Stale label Oct 14, 2024
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed as inactive documentation Improvements or additions to documentation help wanted Extra attention is needed Stale
Projects
None yet
Development

No branches or pull requests

2 participants