Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making six more metrics from MySQL receiver enabled by default #31613

Closed
samiura opened this issue Mar 5, 2024 · 3 comments
Closed

Making six more metrics from MySQL receiver enabled by default #31613

samiura opened this issue Mar 5, 2024 · 3 comments
Labels
enhancement New feature or request needs triage New item requiring triage receiver/mysql

Comments

@samiura
Copy link
Contributor

samiura commented Mar 5, 2024

Component(s)

receiver/mysql

Describe the issue you're reporting

We need to make the following metrics enabled by default ( which are disabled now).

  1. mysql.commands
  2. mysql.client.network.io](http://mysql.client.network.io/)
  3. mysql.connection.count
  4. mysql.connection.errors
  5. mysql.query.count
  6. mysql.query.slow.count
@samiura samiura added the needs triage New item requiring triage label Mar 5, 2024
Copy link
Contributor

github-actions bot commented Mar 5, 2024

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@crobert-1 crobert-1 added the enhancement New feature or request label Mar 6, 2024
@samiura samiura changed the title Making more metrics of Mysql receiver enabled by default Making six more metrics from MySQL receiver enabled by default Mar 6, 2024
@djaglowski
Copy link
Member

djaglowski commented Mar 6, 2024

We need to make the following metrics enabled by default

What makes this a need?

Unfortunately we have have a policy of not enabling metrics by default which were added after the component was labeled beta. (Although this restriction was put in place after the component was labeled beta.)

Personally, I would like to enable many metrics by default but each one will be considered a breaking change at this point. In theory we may be able to do this but it will require a feature gate and potentially a revision of our guidelines for scraper stability.

@samiura
Copy link
Contributor Author

samiura commented Mar 9, 2024

@djaglowski Understood! I will close the issue and try to find a workaround from our distribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage receiver/mysql
Projects
None yet
Development

No branches or pull requests

3 participants