Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The metadata generator doesn't support histogram metrics #26118

Closed
jlegoff opened this issue Aug 28, 2023 · 4 comments
Closed

The metadata generator doesn't support histogram metrics #26118

jlegoff opened this issue Aug 28, 2023 · 4 comments
Assignees
Labels
bug Something isn't working closed as inactive cmd/mdatagen mdatagen command Stale

Comments

@jlegoff
Copy link
Contributor

jlegoff commented Aug 28, 2023

Component(s)

cmd/mdatagen

What happened?

Description

I am writing a component that generates histogram metrics. While writing its metadata.yaml, mdatagen failed because only gauges and sums are supported. This can be checked in the schema here.

Steps to Reproduce

Add histogram metrics in any metadata.yaml file and run mdatagen.

Expected Result

Metadata files should be generated.

Actual Result

mdatagen fails with the following error:

* error decoding 'metrics[apm.service.transaction.duration]': 1 error(s) decoding:

* '' has invalid keys: histogram
doc.go:4: running "mdatagen": exit status 1

Collector version

v0.83.0

Environment information

No response

OpenTelemetry Collector configuration

No response

Log output

No response

Additional context

No response

@jlegoff jlegoff added bug Something isn't working needs triage New item requiring triage labels Aug 28, 2023
@github-actions github-actions bot added the cmd/mdatagen mdatagen command label Aug 28, 2023
@github-actions
Copy link
Contributor

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@sakulali
Copy link
Contributor

sakulali commented Sep 12, 2023

Hello @atoulme , could you please assign this issue to me, i would like to spend some time resolving this feature, thanks

Copy link
Contributor

This issue has been inactive for 60 days. It will be closed in 60 days if there is no activity. To ping code owners by adding a component label, see Adding Labels via Comments, or if you are unsure of which component this issue relates to, please ping @open-telemetry/collector-contrib-triagers. If this issue is still relevant, please ping the code owners or leave a comment explaining why it is still relevant. Otherwise, please close it.

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@github-actions github-actions bot added the Stale label Nov 13, 2023
Copy link
Contributor

This issue has been closed as inactive because it has been stale for 120 days with no activity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working closed as inactive cmd/mdatagen mdatagen command Stale
Projects
None yet
Development

No branches or pull requests

3 participants