Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Datadog] Deploment Tracking is not working #1896

Closed
cemo opened this issue Dec 23, 2020 · 7 comments
Closed

[Datadog] Deploment Tracking is not working #1896

cemo opened this issue Dec 23, 2020 · 7 comments
Assignees
Labels
bug Something isn't working priority:p2 Medium release:allowed-for-ga

Comments

@cemo
Copy link

cemo commented Dec 23, 2020

Describe the bug
Deployment tracking is not working on Datadog Exporter

Steps to reproduce
Add a value to service.version

What did you expect to see?
Deployments on Datadog side.

What did you see instead?
image

What version did you use?
0.17.9

Additional context
Here is a part of a span and relevant tags for it.
image

Would you please take a look?

CC: @KSerrania @mx-psi ,

@cemo cemo added the bug Something isn't working label Dec 23, 2020
@ericmustin
Copy link
Contributor

👋 Hey there. @cemo We're running a bit light over the holidays but wanted to try to help

A couple things to check quickly that could be culprits here

  • Do you have a resource attribute service.name ? or are you setting the service setting in the datadog exporter config? I believe we rely on service.name and not service.namespace here when looking at resource attributes

  • Do you have a deployment.environment resource attribute or an env setting in the datadog exporter config?

I believe, as per the unified service tagging documentation, that service, env, and version are all required in order for deployment tracking to function as expected.

If we verify the above and this is still not working as expected we'd probably want to investigate specific traces in your account, and so for the sake of not sharing PII over open issues i'd encourage you at that point to open a support ticket with datadog here, and we can share the findings/resolution in this issue for future users

@cemo
Copy link
Author

cemo commented Dec 23, 2020

Hi @ericmustin,

Our all environments (production, staging and test) are on the same kubernetes cluster. That is why we are not using datadog exporter config.

We are setting deployment.environment, service.name and service.version (You can see on our previous comment).

image

  1. We set service.name too. service.name is not visible on the trace attributes but I can see the app name in the ui. Before setting it, It was another name.

  2. deployment.environment is visible on the trace too. I can also see at the ui it is set. I can change environment.

So I can clearly say that deployment.environment, service.version and service.name are set. However service.version is not working. There may be another issue too I would be glad if you can check it.

@ericmustin
Copy link
Contributor

@cemo Indeed, taking a look at some of your traces in the backend it seems like environment, service, and version are being correctly added to the traces. It's possible there is some additional work needed on the exporter's use of datadog-agent specific packages to ensure that the version tag is correctly appended to your trace related metrics. I am investigating this internally now, will try to follow up here as soon as I have some next steps or a resolution for you.

@cemo
Copy link
Author

cemo commented Dec 23, 2020

thanks @ericmustin, I guessed same opened issue here because datadog agent can set it. I will be waiting your answer.

@mx-psi
Copy link
Member

mx-psi commented Jan 7, 2021

Hi, generally the same comments apply here #1909 (comment) Traces issues are (for the most part) handled by Eric

@ericmustin
Copy link
Contributor

@cemo 👋 hey there, just wanted to ping that we've put in a PR that should address this, and will aim to have this included as soon as possible, pending review #2010

dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@mx-psi
Copy link
Member

mx-psi commented Sep 2, 2021

This should be fixed, if you are still having issues feel free to reopen it!

@mx-psi mx-psi closed this as completed Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority:p2 Medium release:allowed-for-ga
Projects
None yet
Development

No branches or pull requests

4 participants