Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SignalFx Exporter] Expose HTTP Client settings #16807

Closed
MovieStoreGuy opened this issue Dec 8, 2022 · 4 comments
Closed

[SignalFx Exporter] Expose HTTP Client settings #16807

MovieStoreGuy opened this issue Dec 8, 2022 · 4 comments
Assignees
Labels
enhancement New feature or request needs triage New item requiring triage

Comments

@MovieStoreGuy
Copy link
Contributor

Component(s)

exporter/signalfx

Is your feature request related to a problem? Please describe.

When trying to export metrics to SignalFx, the following error can occur:

{"kind": "exporter", "data_type": "metrics", "name": "signalfx", "error": "Post \"https://ingest.us1.signalfx.com/v2/datapoint\": context deadline exceeded (Client.Timeout exceeded while awaiting headers)", "interval": "31.841960232s"}

The current cause of why it is exceeding timeout is unknown, the current theory is that it is using some HTTP/2 functionality that causing issues but currently not exposed to the end user.

Describe the solution you'd like

Extend the current exporter to support using confighttp.HTTPClientSettings to allow for endusers to configure the http client with greater controls.

Describe alternatives you've considered

Some alternatives could be that http/2 being used is exposed via the config to reduce the complexity of the configuration.
However, I worry if that is reinventing the wheel here since the collector has that functionality abstracted already.

Additional context

I am not sure if this boarder lines on a bug, or an issue on ingestion but having this configuration exposed would allow for the end user to perform their own validation to help with diagnosis with support.

@MovieStoreGuy MovieStoreGuy added enhancement New feature or request needs triage New item requiring triage labels Dec 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 8, 2022

Pinging code owners:

See Adding Labels via Comments if you do not have permissions to add labels yourself.

@tiedotguy
Copy link

Some additional information - golang used to (~1.13 era) have incompatibilities when talking with AWS LBs over HTTP/2 (I believe when LBs needed to shut down a long running connection, during LB scaling), I don't know the state of it these days.

Whether this is actually the issue here or not is also unknown, but all other investigation paths so far have failed.

@atoulme
Copy link
Contributor

atoulme commented Dec 10, 2022

Thank you. Please assign this issue to me.

@fatsheep9146
Copy link
Contributor

Thanks! It's yours. @atoulme

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request needs triage New item requiring triage
Projects
None yet
Development

No branches or pull requests

5 participants