Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass zap logger instance to resource detector components #1645

Closed
willarmiros opened this issue Nov 19, 2020 · 1 comment · Fixed by #1745
Closed

Pass zap logger instance to resource detector components #1645

willarmiros opened this issue Nov 19, 2020 · 1 comment · Fixed by #1745
Labels
enhancement New feature or request

Comments

@willarmiros
Copy link
Contributor

It would be nice to log more specific messages about a resource detector's failure, or that it's disabled because it can't find the required metadata. This needs to be done with a zap logger instance, which has to be passed in from the resource detection processor factory to each of the NewDetector methods.

Probably just need to change the interface of the NewDetector method here to accept a logger and update all of the existing detectors accordingly.
@willarmiros
Copy link
Contributor Author

Related: #1586

@willarmiros willarmiros mentioned this issue Nov 19, 2020
Merged
@bogdandrutu bogdandrutu mentioned this issue Dec 2, 2020
Merged
@andrewhsu andrewhsu added the enhancement New feature or request label Jan 6, 2021
dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@iNikem
Implement InstrumentationLibrary translation to jaeger (#1645)
9f0b27b 
* Implement InstrumentationLibrary translation to jaeger

* Add conversion from jaeger to otlp

* Making test more robust
dyladan referenced this issue in dynatrace-oss-contrib/opentelemetry-collector-contrib Jan 29, 2021
@bogdandrutu
Fix build after merging #1645 (#1793)
3f090e3 
Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Pass processor params to the detectors bogdandrutu/opentelemetry-collector-contrib
2 participants
@andrewhsu @willarmiros