From d68e5a7221566b91a247c717ed3634269e0c5dbe Mon Sep 17 00:00:00 2001 From: Roger Coll Date: Mon, 13 Jan 2025 00:02:35 +0100 Subject: [PATCH] [chore]: do not skip Sudo integration tests (#36941) #### Description Reusing the `GOTEST_INTEGRATION_OPT` was skipping Sudo tests `-skip Sudo` #### Link to tracking issue Fixes https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/36920#discussion_r1895904537 #### Testing #### Documentation Co-authored-by: Sean Marciniak <30928402+MovieStoreGuy@users.noreply.github.com> --- Makefile.Common | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile.Common b/Makefile.Common index ff753533d19f..0d65c3be5c96 100644 --- a/Makefile.Common +++ b/Makefile.Common @@ -30,7 +30,7 @@ GO_BUILD_LDFLAGS="-s -w" GOTEST_TIMEOUT?= 600s GOTEST_OPT?= -race -timeout $(GOTEST_TIMEOUT) -parallel 4 --tags=$(GO_BUILD_TAGS) GOTEST_INTEGRATION_OPT?= -race -timeout 360s -parallel 4 -skip Sudo -GOTEST_INTEGRATION_OPT_SUDO= $(GOTEST_INTEGRATION_OPT) -exec sudo -run Sudo +GOTEST_INTEGRATION_OPT_SUDO?= -race -timeout 360s -parallel 4 -exec sudo -run Sudo GOTEST_OPT_WITH_COVERAGE = $(GOTEST_OPT) -coverprofile=coverage.txt -covermode=atomic GOTEST_OPT_WITH_INTEGRATION=$(GOTEST_INTEGRATION_OPT) -tags=integration,$(GO_BUILD_TAGS) GOTEST_OPT_WITH_INTEGRATION_SUDO=$(GOTEST_INTEGRATION_OPT_SUDO) -tags=integration,$(GO_BUILD_TAGS)