Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Configure PR Bots with CLA (Renovate) #306

Closed
markwolff opened this issue Mar 3, 2020 · 23 comments
Closed

Configure PR Bots with CLA (Renovate) #306

markwolff opened this issue Mar 3, 2020 · 23 comments
Assignees

Comments

@markwolff
Copy link
Member

We have a PR which configures the Renovate bot to automatically create PRs on the JS repo to update dependencies to the latest versions. Currently it is blocked since the bot has not signed the CNCF CLA. How can we configure the bot to "sign" the CLA?

/cc @SergeyKanzhelev

@SergeyKanzhelev
Copy link
Member

SergeyKanzhelev commented Mar 5, 2020

@tedsuo will follow up on policies to enable bots and integrations and how CLA must work

@mayurkale22
Copy link
Member

@tedsuo any update here?

@dyladan
Copy link
Member

dyladan commented Apr 29, 2020

Seems like there is no way to get Renovate configured because of the CLA requirements. As a workaround, we can use the Forking Renovate plugin. Can an OpenTelemetry owner please enable this on the https://github.com/open-telemetry/opentelemetry-js and https://github.com/open-telemetry/opentelemetry-js-contrib repos?

@open-telemetry/admins

@lizthegrey
Copy link
Member

Sorry for the delay, I failed to actually get https://lfcla.com/ running, but it was on my plate. Can we defer for a second so I can try to get it up and running?

@lizthegrey
Copy link
Member

In particular, https://lists.cloudfoundry.org/g/cf-dev/topic/34227989?p=Created,,,20,2,0,0::recentpostdate%2Fsticky,,,20,2,0,34227989 says that it's a supported feature to exempt bots in the new CLA tool.

@dyladan
Copy link
Member

dyladan commented Apr 29, 2020

sounds good to me thanks

@lizthegrey
Copy link
Member

We have gotten approval from CNCF to migrate, we're just doing the details now.

@dyladan
Copy link
Member

dyladan commented May 13, 2020

@lizthegrey any update?

@lizthegrey
Copy link
Member

Thanks for the reminder, pinging CNCF

@dyladan
Copy link
Member

dyladan commented May 20, 2020

@lizthegrey sorry to keep bothering you, but is there an update on this?

@lizthegrey
Copy link
Member

I emailed CNCF to ask for an update, but given that it hasn't happened so far, I'm not going to block any longer.

@dyladan
Copy link
Member

dyladan commented May 20, 2020

If that's the case can an owner install the Forking Renovate plugin on both nodejs repositories?

@lizthegrey
Copy link
Member

@open-telemetry/technical-committee I believe has the bits to do this.

@dyladan
Copy link
Member

dyladan commented Jun 3, 2020

Someone (I assume @open-telemetry/technical-committee) began the process of installing renovate on our contrib repo (the process was already started on our main repo), but the issue still remains that we cannot merge the PRs because the bot has not "signed" the CLA. Installing Forking Renovate instead of Renovate should solve this issue.

@lizthegrey
Copy link
Member

@dyladan we have successfully gotten LF/CNCF approval to install the new CLA bot, and are working on implementation!

@dyladan
Copy link
Member

dyladan commented Jun 3, 2020

Great! Any ETA?

@lizthegrey
Copy link
Member

This week!

@lizthegrey
Copy link
Member

Once the CLA bot is installed, we'll need you to retrigger CI on at least one pull with the traditional Renovate bot, and then I can get it added as an override.

@lizthegrey
Copy link
Member

lizthegrey commented Jun 5, 2020

New bot is installed as per #309. Please trigger at least one PR with the Renovate bot so I can forward the approval link to the CNCF triage desk to be allowlisted.

@dyladan
Copy link
Member

dyladan commented Jun 5, 2020

Not sure which link you need from the PR, but here is a direct link to the PR bot's response open-telemetry/opentelemetry-js#829 (comment)

@lizthegrey
Copy link
Member

Thank you! Filed https://jira.linuxfoundation.org/servicedesk/customer/portal/4/SUPPORT-1388 with CNCF, they'll get it allowlisted in short order.

@lizthegrey
Copy link
Member

Should be allowlisted. Please use commands to ask bot to rebase or reopen pull.

@lizthegrey
Copy link
Member

"EasyCLA check passed. You are authorized to contribute."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants