Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time taken by each constraint to validate the resources #1496

Open
priyamshet opened this issue Aug 13, 2021 · 11 comments
Open

Time taken by each constraint to validate the resources #1496

priyamshet opened this issue Aug 13, 2021 · 11 comments
Labels
enhancement New feature or request Metrics triaged

Comments

@priyamshet
Copy link
Contributor

Describe the solution you'd like
Log/report total(start/end) time taken by each constraint to validate all the resources

Anything else you would like to add:
[Miscellaneous information that will assist in solving the issue.]

Environment:

  • Gatekeeper version:
  • Kubernetes version: (use kubectl version):
@priyamshet priyamshet added the enhancement New feature or request label Aug 13, 2021
@ritazh
Copy link
Member

ritazh commented Aug 18, 2021

@priyamshet are you interested in this metric for audit or admission request?

@ritazh ritazh added the Metrics label Aug 18, 2021
@maxsmythe
Copy link
Contributor

@ritazh @sozercan @shomron

I think this is another thing that could be made easier by using Go to coordinate constraint execution. Gonna file a bug on the constraint framework so we can start tracking the benefits better.

@maxsmythe
Copy link
Contributor

Created as open-policy-agent/frameworks#135

@priyamshet
Copy link
Contributor Author

@priyamshet are you interested in this metric for audit or admission request?

Mostly for audit, We are looking at using this information to profile the constraints execution, to understand how long each constraint takes to do the required auditing against all resources in cluster.

We see audit happens here but logs show audit_started and audit_finished but there is no information/logs/duration at the individual constraint level.

@stale
Copy link

stale bot commented Jul 23, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Jul 23, 2022
@maxsmythe
Copy link
Contributor

gator validate provides some timing information, LMK if this is helpful

@maxsmythe
Copy link
Contributor

@ritazh ritazh removed the wontfix This will not be worked on label Jul 30, 2022
@stale
Copy link

stale bot commented Sep 28, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Sep 28, 2022
@maxsmythe maxsmythe removed the stale label Sep 30, 2022
@maxsmythe
Copy link
Contributor

Having this on a live cluster may be good for debugging.

@stale
Copy link

stale bot commented Nov 29, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Nov 29, 2022
@maxsmythe maxsmythe added triaged and removed stale labels Nov 29, 2022
@maxsmythe
Copy link
Contributor

open-policy-agent/frameworks#263

is aimed at enabling this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Metrics triaged
Projects
None yet
Development

No branches or pull requests

3 participants