From 05638fd76296d376f02003a64af3915183149bc4 Mon Sep 17 00:00:00 2001 From: Fish-pro Date: Fri, 10 Feb 2023 23:08:13 +0800 Subject: [PATCH] feat: add unconvert check for golang-lint (#2554) Signed-off-by: Zechun Chen --- .golangci.yaml | 1 + pkg/metrics/registry/registry.go | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.golangci.yaml b/.golangci.yaml index 0dbb9dcd651..2141ad99f57 100644 --- a/.golangci.yaml +++ b/.golangci.yaml @@ -45,5 +45,6 @@ linters: - revive # replacement for golint - staticcheck - typecheck + - unconvert - unused - whitespace diff --git a/pkg/metrics/registry/registry.go b/pkg/metrics/registry/registry.go index 002806b5950..6400eee0e6b 100644 --- a/pkg/metrics/registry/registry.go +++ b/pkg/metrics/registry/registry.go @@ -60,7 +60,7 @@ func newExporterSet(exporters map[string]StartExporter) *exporterSet { func (es *exporterSet) String() string { contents := make([]string, 0) for k := range es.assignedExporters { - contents = append(contents, string(k)) + contents = append(contents, k) } return fmt.Sprintf("%s", contents) }