Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Moq dependency with a different Mocking library #76

Closed
bacherfl opened this issue Aug 9, 2023 · 0 comments · Fixed by #79
Closed

Replace Moq dependency with a different Mocking library #76

bacherfl opened this issue Aug 9, 2023 · 0 comments · Fixed by #79

Comments

@bacherfl
Copy link
Contributor

bacherfl commented Aug 9, 2023

Due to the controversies around the Moq library (see https://github.com/moq/moq/issues/1372), we may want to consider switching to another mocking library, like e.g. NSubstitute to avoid any privacy issues.
[1] Contains an example of how this was done by another previous Moq user.

Note: Currently we are using v4.18 of Moq, and the controversial change has been introduced with v4.20 and above, so currently this repo is not directly affected by the change. However, we should not merge any renovate PRs bumping the Moq dependency

References:
[1] Afterlife-Guide/AppSettings.Merge#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant