Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Refactor emulator test nonce tracking #5744

Closed
Tracked by #5912
sideninja opened this issue Apr 19, 2024 · 1 comment
Closed
Tracked by #5912

[EVM] Refactor emulator test nonce tracking #5744

sideninja opened this issue Apr 19, 2024 · 1 comment
Assignees
Labels
Stale Label used when marking an issue stale.

Comments

@sideninja
Copy link
Contributor

Right now emulator tests rely on test account nonce which is tracked globally and this means if a test is run independently it might fail because it relies on nonce being updated by others and vice-versa.

Example see: https://github.com/onflow/flow-go/pull/5614/files/7ef18932a517b3523b1a86ad30c3494b1d84749f#diff-759752553abf911832d94d89fd906fe87038d8816fdad2f2a1cd02e2574c61e5R308

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Jul 23, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Stale Label used when marking an issue stale.
Projects
None yet
Development

No branches or pull requests

1 participant