Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Access] Clean up blockID argument from deriveTransactionStatus #5559

Closed
UlyanaAndrukhiv opened this issue Mar 19, 2024 · 0 comments · Fixed by #5619
Closed

[Access] Clean up blockID argument from deriveTransactionStatus #5559

UlyanaAndrukhiv opened this issue Mar 19, 2024 · 0 comments · Fixed by #5619
Assignees
Labels

Comments

@UlyanaAndrukhiv
Copy link
Contributor

Problem Definition

Currently, the deriveTransactionStatus function which is used to determine the status of a transaction has unused argument blockID. This unused argument adds unnecessary complexity to the function and may confuse developers who are trying to understand its purpose.

Proposed Solution

To improve code clarity and remove unnecessary complexity, we should remove the unused blockID argument from the deriveTransactionStatus function. Additionally, we need to update the documentation to reflect this change.

Definition of Done

  • Remove the unused blockID argument from the deriveTransactionStatus function.
  • Update the documentation to reflect the updated signature and behavior of the function.
  • Ensure that the function continues to accurately determine the status of a transaction after the removal of the unused argument.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants