-
Notifications
You must be signed in to change notification settings - Fork 180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EVM] Bridged account creation event consolidation #5414
Comments
I think we ideally should do the reverse, emitting all the events with type A.f8d6e0586b0a20c7.X then we don't need any special handling on access nodes or flow go. thoughts? |
then if we shard multiple EVMs the events won't cause any issue. |
Sounds good 👍 This will only require a small change in the EVM Gateway, for the indexer component. |
We should also include the event definitions in the access(all)
event BlockExecuted(
height: UInt64,
hash: String,
totalSupply: Int,
parentHash: String,
receiptRoot: String,
transactionHashes: [String]
)
access(all)
event TransactionExecuted(
blockHeight: UInt64,
blockHash: String,
transactionHash: String,
encodedTransaction: String,
failed: Bool,
vmError: String,
transactionType: UInt8,
gasConsumed: UInt64,
deployedContractAddress: String,
returnedValue: String,
logs: String
) This will be helpful for other tools (such as the Cadence testing framework), to make use of these types. |
The consensus was to just rollback special even type IDs for EVM, and use the generic type ID signature. |
Currently, the event emitted for COA account creation doesn't have a type that is consistent with other EVM events. The event type ID right now is:
A.f8d6e0586b0a20c7.EVM.BridgedAccountCreated
.This is wrong for two reasons:
EVM.{name}
The event should probably be renamed to:
EVM.COACreated
orEVM.CreatedCOA
.The text was updated successfully, but these errors were encountered: