Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EVM] Change direct call hash calculation #5370

Closed
sideninja opened this issue Feb 9, 2024 · 0 comments · Fixed by #5369
Closed

[EVM] Change direct call hash calculation #5370

sideninja opened this issue Feb 9, 2024 · 0 comments · Fixed by #5369
Assignees

Comments

@sideninja
Copy link
Contributor

Direct call custom hash calculation causes issues when the call is converted into a geth transaction.

The direct call hash is included in the block as transaction hashes, which means that any client would expect to be able to fetch that transaction and then recalculate the same hash, but since the direct call has a custom hash calculation the transaction calculated hash would differ.

We have to make sure that any client that can fetch the direct call as a transaction would match the hash that was calculated and included in the block.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant