You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we don't allow bootstrapping while we are in EFM, meaning no new nodes can join the network when we have entered it. By using this simplification we have simpler implementation of bootstrapping logic. InstanceParams returns flag from DB to report epoch fallback mode: https://github.com/onflow/flow-go/pull/5113/files#diff-993b1b13f491511e3966413c7eee41741a117e4c3745376574ec3ba475b57e8fR108, if we have bootstrapped after entering EFM this will return always false since we didn't populate that DB flag. Similar reasoning is used in updateEpochMetrics.
Most likely we will need to update logic for producing snapshots but that should go into a separate issue.
Definition of done
Allow bootstrapping nodes in EFM
Nodes that are joining the network in EFM have to carry that information in root snapshot and InstanceParams.EpochFallbackTriggered() should return true in this case. (Most likely dynamic protocol state can be used for that)
Add a test case for bootstrapping a node from an EFM snapshot
The content you are editing has changed. Please copy your edits and refresh the page.
Context
Currently we don't allow bootstrapping while we are in EFM, meaning no new nodes can join the network when we have entered it. By using this simplification we have simpler implementation of bootstrapping logic.
InstanceParams
returns flag from DB to report epoch fallback mode: https://github.com/onflow/flow-go/pull/5113/files#diff-993b1b13f491511e3966413c7eee41741a117e4c3745376574ec3ba475b57e8fR108, if we have bootstrapped after entering EFM this will return always false since we didn't populate that DB flag. Similar reasoning is used inupdateEpochMetrics
.For more details read Jordan's comment.
Most likely we will need to update logic for producing snapshots but that should go into a separate issue.
Definition of done
InstanceParams.EpochFallbackTriggered()
should returntrue
in this case. (Most likely dynamic protocol state can be used for that)Depends on
The text was updated successfully, but these errors were encountered: