Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EFM Recovery] Update bootstrapping process to be able to join the network in EFM. #5127

Closed
1 task done
Tracked by #5103
durkmurder opened this issue Dec 11, 2023 · 0 comments
Closed
1 task done
Tracked by #5103
Assignees
Labels
Protocol Team: Issues assigned to the Protocol Pillar. S-BFT

Comments

@durkmurder
Copy link
Member

durkmurder commented Dec 11, 2023

Context

Currently we don't allow bootstrapping while we are in EFM, meaning no new nodes can join the network when we have entered it. By using this simplification we have simpler implementation of bootstrapping logic. InstanceParams returns flag from DB to report epoch fallback mode: https://github.com/onflow/flow-go/pull/5113/files#diff-993b1b13f491511e3966413c7eee41741a117e4c3745376574ec3ba475b57e8fR108, if we have bootstrapped after entering EFM this will return always false since we didn't populate that DB flag. Similar reasoning is used in updateEpochMetrics.

For more details read Jordan's comment.

Most likely we will need to update logic for producing snapshots but that should go into a separate issue.

Definition of done

  • Allow bootstrapping nodes in EFM
  • Nodes that are joining the network in EFM have to carry that information in root snapshot and InstanceParams.EpochFallbackTriggered() should return true in this case. (Most likely dynamic protocol state can be used for that)
  • Add a test case for bootstrapping a node from an EFM snapshot

Depends on

Preview Give feedback
  1. S-BFT S-Epochs
    durkmurder
@durkmurder durkmurder added Protocol Team: Issues assigned to the Protocol Pillar. S-BFT labels Dec 11, 2023
@durkmurder durkmurder self-assigned this Dec 11, 2023
@franklywatson franklywatson added this to the EFM-Q2 milestone Apr 18, 2024
@kc1116 kc1116 modified the milestones: EFM-Q2, EFM-Q2 Epoch Extensions updates Apr 23, 2024
@jordanschalm jordanschalm self-assigned this Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Protocol Team: Issues assigned to the Protocol Pillar. S-BFT
Projects
None yet
Development

No branches or pull requests

4 participants