Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execution effort recalibration - data collection #5026

Open
4 tasks
janezpodhostnik opened this issue Nov 16, 2023 · 5 comments
Open
4 tasks

Execution effort recalibration - data collection #5026

janezpodhostnik opened this issue Nov 16, 2023 · 5 comments
Assignees
Labels
Execution Cadence Execution Team

Comments

@janezpodhostnik
Copy link
Contributor

janezpodhostnik commented Nov 16, 2023

Problem Definition

Execution effort weights need recalibration.

Initial calibration was done with Flip 753.

Since then the execution effort costs of existing weights have changed, and new weights were added, so a recalibration is needed.

Proposed Solution

This issue deals with data collection.

Two sets of data are needed.

  • Synthetic data should be collected by running generated transactions on benchnet.
  • Actual data should be collected from mainnet transaction execution

Definition of Done

  • Estimate effort to collect synthetic data
  • Collect synthetic data
  • Estimate effort to collect mainnet data
  • Collect mainnet data

Related

https://github.com/onflow/cadence-internal/pull/116

@janezpodhostnik janezpodhostnik added the Execution Cadence Execution Team label Nov 16, 2023
@janezpodhostnik janezpodhostnik self-assigned this Nov 16, 2023
@bluesign
Copy link
Contributor

bluesign commented Nov 16, 2023

isn't this collection will become invalid when atree inlining then again when storehouse implemented?

@janezpodhostnik
Copy link
Contributor Author

@bluesign Yes, it will be.

In the future a recalibration should be done after every network upgrade. This time I just intend to check that we have everything in place to collect data from mainnet easily. The synthetic transactions I used the first time also need more variety now (because of new weights).

@j1010001
Copy link
Member

part of #5598

Copy link
Contributor

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@github-actions github-actions bot added the Stale Label used when marking an issue stale. label Sep 19, 2024
@janezpodhostnik janezpodhostnik removed the Stale Label used when marking an issue stale. label Sep 25, 2024
@j1010001
Copy link
Member

j1010001 commented Nov 1, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Not stale, still planned for the next cycle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Execution Cadence Execution Team
Projects
None yet
Development

No branches or pull requests

3 participants