Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feature to support mutation of primitive values returned by iterators #356

Closed
fxamacker opened this issue Nov 16, 2023 · 1 comment
Closed
Assignees
Labels
E&V Team Execution / Verification / Edge Team enhancement New feature or request

Comments

@fxamacker
Copy link
Member

This feature can be used to speed up both Atree Storage Migration and Cadence migration.

Without this feature, we currently need 2 iterations to update values. The first iteration is to gather all the map keys. Second is to update values by key.

We can reduce the 2 iterations to just 1 iteration. This will speedup migration of many values within large accounts by eliminating an iteration. However, mutable iterations by itself will be somewhat slower than the old way of iterating.

Some discussion about this was on Discord.

@fxamacker fxamacker added enhancement New feature or request E&V Team Execution / Verification / Edge Team labels Nov 16, 2023
@fxamacker fxamacker self-assigned this Nov 16, 2023
@fxamacker
Copy link
Member Author

Closed by #359

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E&V Team Execution / Verification / Edge Team enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant