Truffle migrations verbosity and fixed invalid JSON rpc #416
Conversation
| ); | ||
| const paymentToPaymentV2Condition = await PaymentOutputToPaymentTxCondition.deployed(); |
There was a problem hiding this comment.
ah, so you can deploy same contract multiple times by deployer.deply() just when you try to get it back by deployed() you will get the latest one?
There was a problem hiding this comment.
Yeap you can, you save the instance in memory
There was a problem hiding this comment.
Also <>.new() deploys the contracts silently whereas deployer.deploy(<>) does it verbosely for some reason.....
plasma_framework/truffle-config.js
Outdated
| @@ -2,6 +2,9 @@ require('dotenv').config(); // auto parse env variables from '.env' file | |||
|
|
|||
| const HDWalletProvider = require('@truffle/hdwallet-provider'); | |||
|
|
|||
| const infuraUrl = `${process.env.INFURA_URL || 'https://infura.io/v3/'}/${process.env.INFURA_API_KEY}`; | |||
| const cleanInfuraUrl = infuraUrl.replace(/([^:])(\/\/+)/g, '$1/'); | |||
There was a problem hiding this comment.
do we want to keep the previous comment of Replace double // or is it obvious? (not to me but might just be me
There was a problem hiding this comment.
Yes actually keep the comment, it's definitely not obvious
There was a problem hiding this comment.
reminder: the comment is not added yet
plasma_framework/truffle-config.js
Outdated
| 0, 3, | ||
| ); | ||
| }, | ||
| // Jesus fuck why can't this be a function |
There was a problem hiding this comment.
lol do we want to keep the f word XDD
There was a problem hiding this comment.
Might want to remove the J word as well. Lets try not to offend anyone... 😄
| @@ -0,0 +1,8248 @@ | |||
| # THIS IS AN AUTOGENERATED FILE. DO NOT EDIT THIS FILE DIRECTLY. | |||
There was a problem hiding this comment.
Do we want to support both npm and yarn? They might end up locking different version and bring confusion
There was a problem hiding this comment.
True, I'll remove it. Let's stick with npm for now
| // Jesus fuck why can't this be a function | ||
| provider: new HDWalletProvider( | ||
| [ | ||
| process.env.DEPLOYER_PRIVATEKEY || '0'.repeat(64), |
There was a problem hiding this comment.
I don't really understand, why we would need empty 0s here?
There was a problem hiding this comment.
It fails on tests if the private keys are undefined since infuras wallet provider is not a function, but rather instanciates a class on runtime. This instantiation reads the keys and trys to derive it but immediately throws an error because the keys are undefined. To circumvent this I've made the default keys to be zeros
…racts into 200-migrations-fixes
plasma_framework/truffle-config.js
Outdated
| @@ -2,6 +2,9 @@ require('dotenv').config(); // auto parse env variables from '.env' file | |||
|
|
|||
| const HDWalletProvider = require('@truffle/hdwallet-provider'); | |||
|
|
|||
| const infuraUrl = `${process.env.INFURA_URL || 'https://infura.io/v3/'}/${process.env.INFURA_API_KEY}`; | |||
| const cleanInfuraUrl = infuraUrl.replace(/([^:])(\/\/+)/g, '$1/'); | |||
There was a problem hiding this comment.
reminder: the comment is not added yet
https://github.com/omisego/devops/issues/190
What this commit contains: