You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The code used for choosing the title to display based on local for public views is broken in a few ways on the public side.
We're improperly passing an array of langs to displayTitle, which will cause the "right language" title to not get the proper preference over a "no language indicated" one
more importantly, we're passing the resulting calculated title to linkPretty as the "default" parameter, so it's not even getting used, as that default is only used where there is no title
The lang issue is more subtle and was pre-existing, but the problem with the usage of linkPretty breaks both the language selection and browse heading property selection, and is a 4.0 regression.
The text was updated successfully, but these errors were encountered:
Ultimately the trick here is that we don't have a simple way of having the linkPretty markup but just changing the text part. We can either look at being able to pass in to linkPretty to override the text, or make it easier to get at the same linkPretty markup if we want to construct a link with linkRaw manually (a partial?).
We can make the fix and just manually use the correct matching markup, and may go that way in a bugfix release only, but for future maintainability we'll want to have that markup pattern coming from a common place.
The code used for choosing the title to display based on local for public views is broken in a few ways on the public side.
The lang issue is more subtle and was pre-existing, but the problem with the usage of linkPretty breaks both the language selection and browse heading property selection, and is a 4.0 regression.
The text was updated successfully, but these errors were encountered: