Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check use of "file name" in Sites/block layouts #1113

Closed
zerocrates opened this issue Oct 26, 2017 · 2 comments
Closed

Check use of "file name" in Sites/block layouts #1113

zerocrates opened this issue Oct 26, 2017 · 2 comments
Milestone

Comments

@zerocrates
Copy link
Member

Some of the layouts or their options refer to and/or use "file name" as an option for the display of captions, etc.

For one, we don't usually want to refer to "file" at all, rather Media, and for another there are some functional problems with Media that don't have a backing file like HTML, etc.

@zerocrates zerocrates added this to the November 13 milestone Oct 30, 2017
@zerocrates
Copy link
Member Author

@kimisgold please check this to ensure it addresses the problem(s) you had identified

@kimisgold
Copy link
Member

Tested with both HTML and non-image media. Works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants