Fixed arithmetic operations and ToString() for non-english systems #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 25, 2014 21:46
… ToStringMethod tests work with non-english systems, too
omar
added a commit
that referenced
this pull request
Sep 27, 2014
Fixed arithmetic operations and ToString() for non-english systems
|
Thank Andreas. @GeorgeHahn, @MehdiK - this would need to be transplanted to Humanizer. |
|
Thanks a lot for the heads up @omar :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Arithmetic operations used to pass the "Bits" value to the constructor of the newly constructed ByteSize instance instead of "Bytes" resulting in wrong calculations. Operations now pass the right value to the constructor.
Added some simple test cases to ensure arithmetic functions now work as expected.
ToString() is now culture-invariant. ToStringMethod tests are now successful on non-english systems