Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide the pagination component in the facility staff capacity section if there is only one page. #8992

Closed
1 task
nihal467 opened this issue Nov 4, 2024 · 3 comments · Fixed by #9004
Closed
1 task
Assignees

Comments

@nihal467
Copy link
Member

nihal467 commented Nov 4, 2024

Describe the bug

The pagination component is visible in the staff capacity section of the facility details page, even when there is only one page to display.

To Reproduce
Steps to reproduce the behavior:

Steps to reproduce the issue:

  1. Go to the facility tab.
  2. Click on "View Facility" and scroll down to the staff capacity section.
  3. Observe the pagination component.

Expected behavior

  • The pagination component should only be shown if there is more than one page in the staff capacity section.

Screenshots

Image

@mnshrm
Copy link
Contributor

mnshrm commented Nov 4, 2024

HI @nihal467 @rithviknishad, please assign this issue to me, I wish to work on this

Regards

@mnshrm
Copy link
Contributor

mnshrm commented Nov 5, 2024

Hello @rithviknishad,
Raised PR for the issue, and also linked it, please let me know if any discrepancies are found

Thanks for the opportunity

@mnshrm
Copy link
Contributor

mnshrm commented Nov 7, 2024

Hi @nihal467,
requesting a review again for my pull request as for me the fix is working fine

Regards

@bodhish bodhish moved this from Up Next to In Progress in Care Nov 10, 2024
@github-project-automation github-project-automation bot moved this from In Progress to Done in Care Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
2 participants