Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Facility Spoke linking option is not visible in create facility form #8624

Closed
3 tasks
nihal467 opened this issue Sep 25, 2024 · 7 comments
Closed
3 tasks

Facility Spoke linking option is not visible in create facility form #8624

nihal467 opened this issue Sep 25, 2024 · 7 comments
Assignees
Labels
bug Something isn't working Carried over

Comments

@nihal467
Copy link
Member

Describe the bug

  • In the create facility form, only the spoke facility field heading is visible.
  • We are only able to link a spoke to a facility from the update facility form

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://care.ohc.network/facility/create
  2. See error

Expected behavior

  • we should be able to link a spoke to a new facility from the create facility page itself

Screenshots

image

@nihal467 nihal467 added the bug Something isn't working label Sep 25, 2024
@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Sep 26, 2024

@nihal467 Mind assigning this to me? Thanks!

Edit: At present, SpokeFacilityEditor saves a new spoke relationship as soon as Add Spoke is clicked (which requires a facility Id). So, we would either have to:
(1) hide the Spoke Facilities heading on facility creation page, or
(2) rework that editor; only create the relationship on clicking Update Facility and the editor would just show the new items as usual, but clears on page reload.

@rithviknishad
Copy link
Member

I feel "Spoke Facilities" section can be a follow up page that can be shown after the facility is created. Similar to how bed count / doctor count / etc. is asked as follow up after facility creation.

@github-project-automation github-project-automation bot moved this to Triage in Care Sep 26, 2024
@rithviknishad rithviknishad moved this from Triage to Up Next in Care Sep 26, 2024
@Jacobjeevan
Copy link
Contributor

Jacobjeevan commented Sep 26, 2024

I feel "Spoke Facilities" section can be a follow up page that can be shown after the facility is created. Similar to how bed count / doctor count / etc. is asked as follow up after facility creation.

Hmm, should we reuse the existing component or create a different one to follow the format of bed/staff capacity? Save button in this case just navigates to the new facility page (should reword that to something else since there's no cancel button 🤔 )

image

@bodhish
Copy link
Member

bodhish commented Sep 26, 2024

@rithviknishad @Jacobjeevan spoke assignment is not a common function. Its a rare action.
Do we even need it while creating?

@aparnacoronasafe
Copy link
Member

We need it in Create facility form.

A user will rarely visit the update facility form. This information will just remain absent, unless we place it in the creation form.

@bodhish
Copy link
Member

bodhish commented Sep 27, 2024

@aparnacoronasafe add it as another action in the facility page buttons dropdown?

@aparnacoronasafe
Copy link
Member

It's added in the create facility form now which is good.

The list of spokes is also available on the facility dashboard.

However on spoke dashboard, there is no indication of the hubs such a spoke to linked with. This needs to be added.

@Jacobjeevan Jacobjeevan moved this from Up Next to In Progress in Care Oct 7, 2024
@Jacobjeevan Jacobjeevan moved this from In Progress to Review required in Care Oct 7, 2024
@Jacobjeevan Jacobjeevan moved this from Review required to Done in Care Oct 8, 2024
@Jacobjeevan Jacobjeevan moved this from Done to Review required in Care Oct 8, 2024
@Jacobjeevan Jacobjeevan moved this from Review required to Done in Care Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Carried over
Projects
Status: Done
Development

No branches or pull requests

5 participants