Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing DELETE API Endpoint for Resource Deletion #1987

Closed
soumya-maheshwari opened this issue Mar 18, 2024 · 8 comments
Closed

Missing DELETE API Endpoint for Resource Deletion #1987

soumya-maheshwari opened this issue Mar 18, 2024 · 8 comments

Comments

@soumya-maheshwari
Copy link

Describe the bug
Currently, the Swagger documentation for the Resource API only includes endpoints for retrieving, creating, updating, and partially updating resources. However, there's no mention of a DELETE endpoint for resource deletion.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://care.ohc.network/resource/
  2. Click on all details of any resource
  3. Click on delete record
  4. See error

Expected behavior
The DELETE API endpoint should accept a resource identifier (external_id) as a parameter and delete the corresponding resource from the system.

Screenshots

image

image

@Dareenfadel
Copy link

@soumya-maheshwari could you assign it to me?

@asriram07
Copy link

Screenshot 2024-03-18 163406 @soumya-maheshwari I see in response logs, "DELELTE" option is not present as well. Can you tell me where to find swagger documentation and I guess these APIs are on the backend right?

@asriram07
Copy link

@soumya-maheshwari I found the API documentation, I see there is no delete API present here, that means we need to check on the backend whether this API is defined or Am I missing something?

@rithviknishad rithviknishad transferred this issue from ohcnetwork/care_fe Mar 19, 2024
@soumya-maheshwari
Copy link
Author

soumya-maheshwari commented Mar 19, 2024

@rithviknishad i want to work on this

@prabs222
Copy link

@rithviknishad Can I work on this one?

@rithviknishad
Copy link
Member

Needs confirmation on whether this is needed or not or instead have a cancelled state... cc: @nihal467

@JavidSumra
Copy link

Hey team, I think we just need to update the HTTP method, as it impacts resource and shifting record deletion.

@bodhish
Copy link
Member

bodhish commented Nov 6, 2024

We do not plan to support this feature.

@bodhish bodhish closed this as completed Nov 6, 2024
@github-project-automation github-project-automation bot moved this from Up Next to Done in Care Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

7 participants