Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add created_by and updated_by fields to base model #1697

Closed
sainak opened this issue Nov 6, 2023 · 8 comments
Closed

Add created_by and updated_by fields to base model #1697

sainak opened this issue Nov 6, 2023 · 8 comments
Labels
enhancement New feature or request

Comments

@sainak
Copy link
Member

sainak commented Nov 6, 2023

Add created_by and updated_by fields to base model to track user that made changes to the objects

@AnkurPrabhu
Copy link
Contributor

Hey can i work on this one ?

@sainak
Copy link
Member Author

sainak commented Mar 2, 2024

sure

@AnkurPrabhu
Copy link
Contributor

@sainak just wanted to confirm this will have

  1. a migration file for the addition of two fields in class BaseModel
  2. all the changes where any object of a class extended by BaseModel is either created or modified right ?

@sainak
Copy link
Member Author

sainak commented Mar 3, 2024

@sainak just wanted to confirm this will have

1. a migration file for the addition of two fields in class BaseModel

2. all the changes where any object of a class extended by BaseModel is either created or modified right ?

Yes, and also override perform create/update function of viewsets to pass the user while saving

@AnkurPrabhu
Copy link
Contributor

@sainak will the migrations files be a separate pr ?

@AnkurPrabhu
Copy link
Contributor

@sainak can you pls take a look at the initial pr just wanted to confirm if im in the right direction or not.
made the migration field and updated the created_by and updated_by fields for some viewsets, once you approve the approach will do it for all the other viewsets

@AnkurPrabhu
Copy link
Contributor

@sainak i have updated the pr with all the necessary changes pls take a look

@sainak sainak mentioned this issue Apr 12, 2024
4 tasks
@Harsh-D-2004
Copy link
Contributor

is this still open??

@vigneshhari vigneshhari closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants