diff --git a/web/client/components/data/download/DownloadDialog.jsx b/web/client/components/data/download/DownloadDialog.jsx index 63aac13771..63309e1e49 100644 --- a/web/client/components/data/download/DownloadDialog.jsx +++ b/web/client/components/data/download/DownloadDialog.jsx @@ -67,7 +67,7 @@ class DownloadDialog extends React.Component { }; render() { - return ( + return ( diff --git a/web/client/components/manager/users/GroupDialog.jsx b/web/client/components/manager/users/GroupDialog.jsx index 16124d597b..308cf70141 100644 --- a/web/client/components/manager/users/GroupDialog.jsx +++ b/web/client/components/manager/users/GroupDialog.jsx @@ -208,6 +208,7 @@ class GroupDialog extends React.Component { id="mapstore-group-dialog" className="group-edit-dialog" style={assign({}, this.props.style, {display: this.props.show ? "block" : "none"})} + draggable={false} > - {panel} - ); + return ( + + + + {panel} + + + ); } return panel; }; diff --git a/web/client/components/mapcontrols/measure/MeasureDialog.jsx b/web/client/components/mapcontrols/measure/MeasureDialog.jsx index 22082ac708..901e5a002b 100644 --- a/web/client/components/mapcontrols/measure/MeasureDialog.jsx +++ b/web/client/components/mapcontrols/measure/MeasureDialog.jsx @@ -76,7 +76,7 @@ class MeasureDialog extends React.Component { style={this.props.style}> - : ( + : (
  diff --git a/web/client/components/mapcontrols/measure/__tests__/MeasureDialog-test.jsx b/web/client/components/mapcontrols/measure/__tests__/MeasureDialog-test.jsx index 659d70899e..27c870b48d 100644 --- a/web/client/components/mapcontrols/measure/__tests__/MeasureDialog-test.jsx +++ b/web/client/components/mapcontrols/measure/__tests__/MeasureDialog-test.jsx @@ -48,7 +48,7 @@ describe("test the MeasureDialog", () => { let measurement = {}; const mc = ReactDOM.render(, document.getElementById("container")); expect(mc).toExist(); - const dialog = document.getElementById('measure'); + const dialog = document.getElementById('measure-dialog'); expect(dialog).toExist(); }); @@ -79,7 +79,7 @@ describe("test the MeasureDialog", () => { const btnGroups = dom.getElementsByClassName('btn-group'); expect(btnGroups.length).toBe(2); - const dialog = document.getElementById('measure'); + const dialog = document.getElementById('measure-dialog'); expect(dialog).toNotExist(); expect(spyMount.calls.length).toBe(1); expect(spyMount).toHaveBeenCalledWith(showCoordinateEditor); @@ -119,7 +119,7 @@ describe("test the MeasureDialog", () => { const btnGroups = dom.getElementsByClassName('btn-group'); expect(btnGroups.length).toBe(2); - const dialog = document.getElementById('measure'); + const dialog = document.getElementById('measure-dialog'); expect(dialog).toNotExist(); expect(spyMount.calls.length).toBe(1); expect(spyToggleMeasure.calls.length).toBe(1); diff --git a/web/client/components/misc/Dialog.jsx b/web/client/components/misc/Dialog.jsx index 7ef917539d..1ccad14564 100644 --- a/web/client/components/misc/Dialog.jsx +++ b/web/client/components/misc/Dialog.jsx @@ -27,7 +27,8 @@ class Dialog extends React.Component { onClickOut: PropTypes.func, modal: PropTypes.bool, start: PropTypes.object, - draggable: PropTypes.bool + draggable: PropTypes.bool, + bounds: PropTypes.object }; static defaultProps = { @@ -35,7 +36,7 @@ class Dialog extends React.Component { backgroundStyle: { background: "rgba(0,0,0,.5)" }, - start: {x: 0, y: 0}, + start: {x: 0, y: 150}, className: "modal-dialog modal-content", maskLoading: false, containerClassName: "", @@ -43,7 +44,8 @@ class Dialog extends React.Component { bodyClassName: "modal-body", footerClassName: "modal-footer", modal: false, - draggable: true + draggable: true, + bounds: 'parent' }; renderLoading = () => { @@ -72,7 +74,7 @@ class Dialog extends React.Component { }; render() { - const body = (
+ const body = (
{this.renderRole('header')}
@@ -84,7 +86,7 @@ class Dialog extends React.Component { {this.renderRole('footer')}
: }
); - const dialog = this.props.draggable ? ( + const dialog = this.props.draggable ? ( {body} ) : body; let containerStyle = assign({}, this.props.style.display ? {display: this.props.style.display} : {}, this.props.backgroundStyle); @@ -105,4 +107,5 @@ class Dialog extends React.Component { }; } + module.exports = Dialog; diff --git a/web/client/plugins/SearchServicesConfig.jsx b/web/client/plugins/SearchServicesConfig.jsx index 724c9c83e9..62c92276d8 100644 --- a/web/client/plugins/SearchServicesConfig.jsx +++ b/web/client/plugins/SearchServicesConfig.jsx @@ -149,7 +149,7 @@ class SearchServicesConfigPanel extends React.Component { const Section = pages && pages[page] || null; return enabled ? ( - + {titleText} { this.isDirty() ? ( diff --git a/web/client/plugins/Settings.jsx b/web/client/plugins/Settings.jsx index 608f098882..528a71325c 100644 --- a/web/client/plugins/Settings.jsx +++ b/web/client/plugins/Settings.jsx @@ -143,7 +143,7 @@ class SettingsButton extends React.Component { {settings} ); } - return ( + return ( diff --git a/web/client/plugins/print/print.css b/web/client/plugins/print/print.css index 08a55f313e..12c35d6164 100644 --- a/web/client/plugins/print/print.css +++ b/web/client/plugins/print/print.css @@ -37,10 +37,6 @@ right: -155px; z-index: 1000; } - -#mapstore-print-panel{ - margin-top: 100px !important; -} #mapstore-print-panel.modal-dialog { z-index: 2000; } diff --git a/web/client/product/components/viewer/about/About.jsx b/web/client/product/components/viewer/about/About.jsx index 63b99a7a1a..f6e53f1eb4 100644 --- a/web/client/product/components/viewer/about/About.jsx +++ b/web/client/product/components/viewer/about/About.jsx @@ -49,7 +49,7 @@ class About extends React.Component { className="map-logo" body={ - }/>) : ( + }/>) : (
); diff --git a/web/client/themes/default/bootstrap-theme.less b/web/client/themes/default/bootstrap-theme.less index bdbcccfce7..d9c063d701 100644 --- a/web/client/themes/default/bootstrap-theme.less +++ b/web/client/themes/default/bootstrap-theme.less @@ -141,6 +141,9 @@ button.close { margin: auto; margin-top: 150px; } + .modal-dialog-draggable { + margin-top: 0; + } } // Dropdown diff --git a/web/client/themes/default/less/panels.less b/web/client/themes/default/less/panels.less index d85c5f1e76..ba31d1ce43 100644 --- a/web/client/themes/default/less/panels.less +++ b/web/client/themes/default/less/panels.less @@ -205,7 +205,7 @@ } } -#mapstore-print-panel, #measure-dialog, #mapstore-about { +#mapstore-print-panel, #measure-dialog, #mapstore-about, #share-panel-dialog { position: absolute; top: 0%; left: 20%;