Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BREAKING CHANGES]: int to long Ids for PreReceiveHook, Deployment Environments, Repository, Org Team, Repo Invitations, Public Key, Project Cards, Organization Invitation, Migrations, GpgKey, Deployment, Authorizations, Accounts / Profiles, Codespace / Workspaces #2941

Merged
merged 6 commits into from
Jun 26, 2024
Merged

[BREAKING CHANGES]: int to long Ids for PreReceiveHook, Deployment Environments, Repository, Org Team, Repo Invitations, Public Key, Project Cards, Organization Invitation, Migrations, GpgKey, Deployment, Authorizations, Accounts / Profiles, Codespace / Workspaces #2941

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9358771
Fixes ids for Releases, Collaborators, and Contributors
nickfloyd Jun 24, 2024
0b1be70
updates the interface for releases
nickfloyd Jun 24, 2024
61922f6
update the obverable release client
nickfloyd Jun 24, 2024
361241b
updates ids from int to long based on GH database schema
nickfloyd Jun 25, 2024
9eb9d89
converts a test condition to use the proper type
nickfloyd Jun 25, 2024
48b3c7f
updates generated paging and observable classes
nickfloyd Jun 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 10 additions & 10 deletions Octokit.Reactive/Clients/IObservableReleasesClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public interface IObservableReleasesClient
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the release</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<Release> Get(string owner, string name, int id);
IObservable<Release> Get(string owner, string name, long id);

/// <summary>
/// Gets a single <see cref="Release"/> for the specified repository.
Expand All @@ -113,7 +113,7 @@ public interface IObservableReleasesClient
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the release</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<Release> Get(long repositoryId, int id);
IObservable<Release> Get(long repositoryId, long id);

/// <summary>
/// Gets a single <see cref="Release"/> for the specified repository.
Expand Down Expand Up @@ -181,7 +181,7 @@ public interface IObservableReleasesClient
/// <param name="id">The id of the release</param>
/// <param name="data">A description of the release to edit</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<Release> Edit(string owner, string name, int id, ReleaseUpdate data);
IObservable<Release> Edit(string owner, string name, long id, ReleaseUpdate data);

/// <summary>
/// Edits an existing <see cref="Release"/> for the specified repository.
Expand All @@ -193,7 +193,7 @@ public interface IObservableReleasesClient
/// <param name="id">The id of the release</param>
/// <param name="data">A description of the release to edit</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<Release> Edit(long repositoryId, int id, ReleaseUpdate data);
IObservable<Release> Edit(long repositoryId, long id, ReleaseUpdate data);

/// <summary>
/// Deletes an existing <see cref="Release"/> for the specified repository.
Expand All @@ -205,7 +205,7 @@ public interface IObservableReleasesClient
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the release to delete</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<Unit> Delete(string owner, string name, int id);
IObservable<Unit> Delete(string owner, string name, long id);

/// <summary>
/// Deletes an existing <see cref="Release"/> for the specified repository.
Expand All @@ -216,7 +216,7 @@ public interface IObservableReleasesClient
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the release to delete</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<Unit> Delete(long repositoryId, int id);
IObservable<Unit> Delete(long repositoryId, long id);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -228,7 +228,7 @@ public interface IObservableReleasesClient
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<ReleaseAsset> GetAllAssets(string owner, string name, int id);
IObservable<ReleaseAsset> GetAllAssets(string owner, string name, long id);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -239,7 +239,7 @@ public interface IObservableReleasesClient
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<ReleaseAsset> GetAllAssets(long repositoryId, int id);
IObservable<ReleaseAsset> GetAllAssets(long repositoryId, long id);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -252,7 +252,7 @@ public interface IObservableReleasesClient
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <param name="options">Options for changing the API response</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<ReleaseAsset> GetAllAssets(string owner, string name, int id, ApiOptions options);
IObservable<ReleaseAsset> GetAllAssets(string owner, string name, long id, ApiOptions options);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -264,7 +264,7 @@ public interface IObservableReleasesClient
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <param name="options">Options for changing the API response</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
IObservable<ReleaseAsset> GetAllAssets(long repositoryId, int id, ApiOptions options);
IObservable<ReleaseAsset> GetAllAssets(long repositoryId, long id, ApiOptions options);

/// <summary>
/// Uploads a <see cref="ReleaseAsset"/> for the specified release.
Expand Down
20 changes: 10 additions & 10 deletions Octokit.Reactive/Clients/ObservableReleasesClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ public IObservable<Release> GetAll(long repositoryId, ApiOptions options)
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the release</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<Release> Get(string owner, string name, int id)
public IObservable<Release> Get(string owner, string name, long id)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Expand Down Expand Up @@ -171,7 +171,7 @@ public IObservable<Release> Get(string owner, string name, string tag)
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the release</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<Release> Get(long repositoryId, int id)
public IObservable<Release> Get(long repositoryId, long id)
{
return _client.Get(repositoryId, id).ToObservable();
}
Expand Down Expand Up @@ -268,7 +268,7 @@ public IObservable<Release> Create(long repositoryId, NewRelease data)
/// <param name="id">The id of the release</param>
/// <param name="data">A description of the release to edit</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<Release> Edit(string owner, string name, int id, ReleaseUpdate data)
public IObservable<Release> Edit(string owner, string name, long id, ReleaseUpdate data)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Expand All @@ -287,7 +287,7 @@ public IObservable<Release> Edit(string owner, string name, int id, ReleaseUpdat
/// <param name="id">The id of the release</param>
/// <param name="data">A description of the release to edit</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<Release> Edit(long repositoryId, int id, ReleaseUpdate data)
public IObservable<Release> Edit(long repositoryId, long id, ReleaseUpdate data)
{
Ensure.ArgumentNotNull(data, nameof(data));

Expand All @@ -304,7 +304,7 @@ public IObservable<Release> Edit(long repositoryId, int id, ReleaseUpdate data)
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the release to delete</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<Unit> Delete(string owner, string name, int id)
public IObservable<Unit> Delete(string owner, string name, long id)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Expand All @@ -321,7 +321,7 @@ public IObservable<Unit> Delete(string owner, string name, int id)
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the release to delete</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<Unit> Delete(long repositoryId, int id)
public IObservable<Unit> Delete(long repositoryId, long id)
{
return _client.Delete(repositoryId, id).ToObservable();
}
Expand All @@ -336,7 +336,7 @@ public IObservable<Unit> Delete(long repositoryId, int id)
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<ReleaseAsset> GetAllAssets(string owner, string name, int id)
public IObservable<ReleaseAsset> GetAllAssets(string owner, string name, long id)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Expand All @@ -353,7 +353,7 @@ public IObservable<ReleaseAsset> GetAllAssets(string owner, string name, int id)
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<ReleaseAsset> GetAllAssets(long repositoryId, int id)
public IObservable<ReleaseAsset> GetAllAssets(long repositoryId, long id)
{
return GetAllAssets(repositoryId, id, ApiOptions.None);
}
Expand All @@ -369,7 +369,7 @@ public IObservable<ReleaseAsset> GetAllAssets(long repositoryId, int id)
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <param name="options">Options for changing the API response</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<ReleaseAsset> GetAllAssets(string owner, string name, int id, ApiOptions options)
public IObservable<ReleaseAsset> GetAllAssets(string owner, string name, long id, ApiOptions options)
{
Ensure.ArgumentNotNullOrEmptyString(owner, nameof(owner));
Ensure.ArgumentNotNullOrEmptyString(name, nameof(name));
Expand All @@ -388,7 +388,7 @@ public IObservable<ReleaseAsset> GetAllAssets(string owner, string name, int id,
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <param name="options">Options for changing the API response</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
public IObservable<ReleaseAsset> GetAllAssets(long repositoryId, int id, ApiOptions options)
public IObservable<ReleaseAsset> GetAllAssets(long repositoryId, long id, ApiOptions options)
{
Ensure.ArgumentNotNull(options, nameof(options));

Expand Down
20 changes: 10 additions & 10 deletions Octokit/Clients/IReleasesClient.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ public interface IReleasesClient
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the release</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<Release> Get(string owner, string name, int id);
Task<Release> Get(string owner, string name, long id);

/// <summary>
/// Gets a single <see cref="Release"/> for the specified repository.
Expand All @@ -113,7 +113,7 @@ public interface IReleasesClient
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the release</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<Release> Get(long repositoryId, int id);
Task<Release> Get(long repositoryId, long id);

/// <summary>
/// Gets a single <see cref="Release"/> for the specified repository.
Expand Down Expand Up @@ -181,7 +181,7 @@ public interface IReleasesClient
/// <param name="id">The id of the release</param>
/// <param name="data">A description of the release to edit</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<Release> Edit(string owner, string name, int id, ReleaseUpdate data);
Task<Release> Edit(string owner, string name, long id, ReleaseUpdate data);

/// <summary>
/// Edits an existing <see cref="Release"/> for the specified repository.
Expand All @@ -193,7 +193,7 @@ public interface IReleasesClient
/// <param name="id">The id of the release</param>
/// <param name="data">A description of the release to edit</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<Release> Edit(long repositoryId, int id, ReleaseUpdate data);
Task<Release> Edit(long repositoryId, long id, ReleaseUpdate data);

/// <summary>
/// Deletes an existing <see cref="Release"/> for the specified repository.
Expand All @@ -205,7 +205,7 @@ public interface IReleasesClient
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the release to delete</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task Delete(string owner, string name, int id);
Task Delete(string owner, string name, long id);

/// <summary>
/// Deletes an existing <see cref="Release"/> for the specified repository.
Expand All @@ -216,7 +216,7 @@ public interface IReleasesClient
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the release to delete</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task Delete(long repositoryId, int id);
Task Delete(long repositoryId, long id);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -228,7 +228,7 @@ public interface IReleasesClient
/// <param name="name">The repository's name</param>
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(string owner, string name, int id);
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(string owner, string name, long id);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -239,7 +239,7 @@ public interface IReleasesClient
/// <param name="repositoryId">The Id of the repository</param>
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(long repositoryId, int id);
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(long repositoryId, long id);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -252,7 +252,7 @@ public interface IReleasesClient
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <param name="options">Options for changing the API response</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(string owner, string name, int id, ApiOptions options);
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(string owner, string name, long id, ApiOptions options);

/// <summary>
/// Gets all <see cref="ReleaseAsset"/> for the specified release of the specified repository.
Expand All @@ -264,7 +264,7 @@ public interface IReleasesClient
/// <param name="id">The id of the <see cref="Release"/>.</param>
/// <param name="options">Options for changing the API response</param>
/// <exception cref="ApiException">Thrown when a general API error occurs.</exception>
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(long repositoryId, int id, ApiOptions options);
Task<IReadOnlyList<ReleaseAsset>> GetAllAssets(long repositoryId, long id, ApiOptions options);

/// <summary>
/// Uploads a <see cref="ReleaseAsset"/> for the specified release.
Expand Down
Loading
Loading