Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing pagination support to Repository Invitations Clients #1665

Closed
4 tasks
ryangribble opened this issue Sep 3, 2017 · 0 comments
Closed
4 tasks
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone

Comments

@ryangribble
Copy link
Contributor

Refer #1659

Implement Pagination on the following clients

IRepositoryInvitationsClient and IObservableRepositoryInvitationsClient

  • GetAllForCurrent()
  • GetAllForRepository(long repositoryId)

Checklist

  • Remove convention test exclusion

  • Add ApiOptions overload

    • make existing methods call new overload with ApiOptions.None
  • Update unit tests

    • Adjust for ApiOptions parameter
    • Add null check for ApiOptions
  • Add pagination Integration tests

    • ReturnsCorrectCountOfXWithoutStart
    • ReturnsCorrectCountOfXWithStart
    • ReturnsDistinctXBasedOnStartPage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Up for grabs Issues that are ready to be worked on by anyone
Projects
None yet
Development

No branches or pull requests

2 participants