diff --git a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs index 4044adde88..65b84a1609 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentReactionsClientTests.cs @@ -146,7 +146,7 @@ async Task<PullRequestData> CreatePullRequest(RepositoryContext context) // Creating a pull request - var pullRequest = new NewPullRequest("Nice title for the pull request", branchName, "master"); + var pullRequest = new NewPullRequest("Nice title for the pull request", branchName, "master", false); var createdPullRequest = await _github.PullRequest.Create(Helper.UserName, repoName, pullRequest); var data = new PullRequestData diff --git a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs index ad51225dbe..a62f45106d 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestReviewCommentsClientTests.cs @@ -870,7 +870,7 @@ async Task<PullRequestData> CreatePullRequest(RepositoryContext context, string // Creating a pull request - var pullRequest = new NewPullRequest("Nice title for the pull request", branch, "master"); + var pullRequest = new NewPullRequest("Nice title for the pull request", branch, "master", false); var createdPullRequest = await _github.PullRequest.Create(Helper.UserName, repoName, pullRequest); var data = new PullRequestData diff --git a/Octokit.Tests.Integration/Clients/PullRequestReviewRequestsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestReviewRequestsClientTests.cs index b139b3b145..c14915dd96 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestReviewRequestsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestReviewRequestsClientTests.cs @@ -244,7 +244,7 @@ static async Task<int> CreateTheWorld(IGitHubClient github, RepositoryContext co await github.Git.Reference.Create(context.RepositoryOwner, context.RepositoryName, new NewReference("refs/heads/my-branch", featureBranchCommit2.Sha)); // create a pull request - var pullRequest = new NewPullRequest("Nice title for the pull request", "my-branch", "master"); + var pullRequest = new NewPullRequest("Nice title for the pull request", "my-branch", "master", false); var createdPullRequest = await github.PullRequest.Create(context.RepositoryOwner, context.RepositoryName, pullRequest); // Create review requests (optional) diff --git a/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs b/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs index 9afd3ae656..9be4e8cc03 100644 --- a/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs +++ b/Octokit.Tests.Integration/Clients/PullRequestsClientTests.cs @@ -32,7 +32,7 @@ public async Task CanCreate() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); Assert.Equal("a pull request", result.Title); } @@ -42,7 +42,7 @@ public async Task CanCreateWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(_context.Repository.Id, newPullRequest); Assert.Equal("a pull request", result.Title); } @@ -52,7 +52,7 @@ public async Task CanGetForRepository() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var pullRequests = await _fixture.GetAllForRepository(Helper.UserName, _context.RepositoryName); @@ -67,7 +67,7 @@ public async Task CanGetForRepositoryWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var pullRequests = await _fixture.GetAllForRepository(_context.Repository.Id); @@ -81,7 +81,7 @@ public async Task CanGetWithAssigneesForRepository() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); // Add an assignee @@ -104,7 +104,7 @@ public async Task CanGetWithAssigneesForRepositoryWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(_context.Repository.Id, newPullRequest); // Add an assignee @@ -127,7 +127,7 @@ public async Task ReturnsCorrectCountOfPullRequestsWithoutStart() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var options = new ApiOptions @@ -147,7 +147,7 @@ public async Task ReturnsCorrectCountOfPullRequestsWithoutStartWithRepositoryId( { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var options = new ApiOptions @@ -167,8 +167,8 @@ public async Task ReturnsCorrectCountOfPullRequestsWithStart() { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -190,8 +190,8 @@ public async Task ReturnsCorrectCountOfPullRequestsWithStartWithRepositoryId() { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -213,8 +213,8 @@ public async Task ReturnsDistinctPullRequestsBasedOnStartPage() { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -243,8 +243,8 @@ public async Task ReturnsDistinctPullRequestsBasedOnStartPageWithRepositoryId() { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -273,7 +273,7 @@ public async Task CanGetOpenPullRequest() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", true); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var openPullRequests = new PullRequestRequest { State = ItemStateFilter.Open }; @@ -281,6 +281,7 @@ public async Task CanGetOpenPullRequest() Assert.Equal(1, pullRequests.Count); Assert.Equal(result.Title, pullRequests[0].Title); + Assert.Equal(true, pullRequests[0].MaintainerCanModify); } [IntegrationTest] @@ -288,7 +289,7 @@ public async Task CanGetOpenPullRequestWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var openPullRequests = new PullRequestRequest { State = ItemStateFilter.Open }; @@ -296,6 +297,7 @@ public async Task CanGetOpenPullRequestWithRepositoryId() Assert.Equal(1, pullRequests.Count); Assert.Equal(result.Title, pullRequests[0].Title); + Assert.Equal(false, pullRequests[0].MaintainerCanModify); } [IntegrationTest] @@ -303,7 +305,7 @@ public async Task ReturnsCorrectCountOfPullRequestsWithoutStartParameterized() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var options = new ApiOptions @@ -324,7 +326,7 @@ public async Task ReturnsCorrectCountOfPullRequestsWithoutStartParameterizedWith { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var options = new ApiOptions @@ -345,8 +347,8 @@ public async Task ReturnsCorrectCountOfPullRequestsWithStartParameterized() { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -369,8 +371,8 @@ public async Task ReturnsCorrectCountOfPullRequestsWithStartParameterizedWithRep { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); var result = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -393,8 +395,8 @@ public async Task ReturnsDistinctPullRequestsBasedOnStartPageParameterized() { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -425,8 +427,8 @@ public async Task ReturnsDistinctPullRequestsBasedOnStartPageParameterizedWithRe { await CreateTheWorld(); - var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master"); - var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master"); + var newPullRequest1 = new NewPullRequest("a pull request 1", branchName, "master", false); + var newPullRequest2 = new NewPullRequest("a pull request 2", otherBranchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest1); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); @@ -457,7 +459,7 @@ public async Task IgnoresOpenPullRequest() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var openPullRequests = new PullRequestRequest { State = ItemStateFilter.Closed }; @@ -471,7 +473,7 @@ public async Task IgnoresOpenPullRequestWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var openPullRequests = new PullRequestRequest { State = ItemStateFilter.Closed }; @@ -485,7 +487,7 @@ public async Task CanUpdate() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var updatePullRequest = new PullRequestUpdate { Title = "updated title", Body = "Hello New Body", Base = "my-other-branch" }; @@ -501,7 +503,7 @@ public async Task CanUpdateWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var updatePullRequest = new PullRequestUpdate { Title = "updated title", Body = "Hello New Body", Base = "my-other-branch" }; @@ -517,7 +519,7 @@ public async Task CanClose() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var updatePullRequest = new PullRequestUpdate { State = ItemState.Closed }; @@ -533,7 +535,7 @@ public async Task CanFindClosedPullRequest() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var updatePullRequest = new PullRequestUpdate { State = ItemState.Closed }; @@ -550,10 +552,10 @@ public async Task CanSortPullRequests() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); - var newPullRequest2 = new NewPullRequest("another pull request", otherBranchName, "master"); + var newPullRequest2 = new NewPullRequest("another pull request", otherBranchName, "master", false); var anotherPullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); var updatePullRequest = new PullRequestUpdate { Body = "This is the body" }; @@ -573,10 +575,10 @@ public async Task CanSpecifyDirectionOfSort() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); - var newPullRequest2 = new NewPullRequest("another pull request", otherBranchName, "master"); + var newPullRequest2 = new NewPullRequest("another pull request", otherBranchName, "master", false); var anotherPullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest2); var pullRequests = await _fixture.GetAllForRepository(Helper.UserName, _context.RepositoryName, new PullRequestRequest { SortDirection = SortDirection.Ascending }); @@ -591,7 +593,7 @@ public async Task IsNotMergedInitially() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var result = await _fixture.Merged(Helper.UserName, _context.RepositoryName, pullRequest.Number); @@ -604,7 +606,7 @@ public async Task IsNotMergedInitiallyWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var result = await _fixture.Merged(_context.Repository.Id, pullRequest.Number); @@ -617,7 +619,7 @@ public async Task CanBeMerged() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { CommitMessage = "thing the thing" }; @@ -631,7 +633,7 @@ public async Task CanBeMergedWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { CommitMessage = "thing the thing" }; @@ -645,7 +647,7 @@ public async Task CanBeMergedWithNoOptionalInput() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest(); @@ -659,7 +661,7 @@ public async Task CanBeMergedWithShaSpecified() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { CommitMessage = "thing the thing", Sha = pullRequest.Head.Sha }; @@ -673,7 +675,7 @@ public async Task CanBeMergedWithMergeMethod() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("squash commit pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("squash commit pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { CommitMessage = "fake commit message", CommitTitle = "fake title", MergeMethod = PullRequestMergeMethod.Merge }; @@ -689,7 +691,7 @@ public async Task CanBeMergedWithSquashMethod() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("squash commit pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("squash commit pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { CommitMessage = "fake commit message", CommitTitle = "fake title", MergeMethod = PullRequestMergeMethod.Squash }; @@ -705,7 +707,7 @@ public async Task CanBeMergedWithRebaseMethod() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("squash commit pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("squash commit pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { CommitMessage = "fake commit message", CommitTitle = "fake title", MergeMethod = PullRequestMergeMethod.Rebase }; @@ -722,7 +724,7 @@ public async Task CannotBeMergedDueMismatchConflict() await CreateTheWorld(); var fakeSha = new string('f', 40); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { Sha = fakeSha }; @@ -741,7 +743,7 @@ public async Task CannotBeMergedDueNotInMergeableState() var masterCommit = await CreateCommit("Commit in master", newMasterTree.Sha, master.Object.Sha); await _github.Git.Reference.Update(Helper.UserName, _context.RepositoryName, "heads/master", new ReferenceUpdate(masterCommit.Sha)); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); await Task.Delay(TimeSpan.FromSeconds(5)); @@ -762,7 +764,7 @@ public async Task UpdatesMaster() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var merge = new MergePullRequest { CommitMessage = "thing the thing" }; @@ -778,7 +780,7 @@ public async Task CanBrowseCommits() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var result = await _fixture.Commits(Helper.UserName, _context.RepositoryName, pullRequest.Number); @@ -792,7 +794,7 @@ public async Task CanBrowseCommitsWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); var result = await _fixture.Commits(_context.Repository.Id, pullRequest.Number); @@ -806,7 +808,7 @@ public async Task CanGetCommitsAndCommentCount() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); // create new commit for branch @@ -838,7 +840,7 @@ public async Task CanGetCommitsAndCommentCountWithRepositoryId() { await CreateTheWorld(); - var newPullRequest = new NewPullRequest("a pull request", branchName, "master"); + var newPullRequest = new NewPullRequest("a pull request", branchName, "master", false); var pullRequest = await _fixture.Create(Helper.UserName, _context.RepositoryName, newPullRequest); // create new commit for branch diff --git a/Octokit.Tests.Integration/Helpers/RepositorySetupHelper.cs b/Octokit.Tests.Integration/Helpers/RepositorySetupHelper.cs index 3bfa7f4d02..b4e8190028 100644 --- a/Octokit.Tests.Integration/Helpers/RepositorySetupHelper.cs +++ b/Octokit.Tests.Integration/Helpers/RepositorySetupHelper.cs @@ -63,7 +63,7 @@ public static async Task<Reference> CreateTheWorld(this IGitHubClient client, Re public static async Task<PullRequest> CreatePullRequest(this IGitHubClient client, Repository repository, string branch = "my-branch") { - var pullRequest = new NewPullRequest("Nice title for the pull request", branch, "master"); + var pullRequest = new NewPullRequest("Nice title for the pull request", branch, "master", false); var createdPullRequest = await client.PullRequest.Create(repository.Owner.Login, repository.Name, pullRequest); return createdPullRequest; diff --git a/Octokit.Tests/Clients/PullRequestsClientTests.cs b/Octokit.Tests/Clients/PullRequestsClientTests.cs index f30d2e89ca..16a07f9241 100644 --- a/Octokit.Tests/Clients/PullRequestsClientTests.cs +++ b/Octokit.Tests/Clients/PullRequestsClientTests.cs @@ -236,7 +236,7 @@ public class TheCreateMethod [Fact] public async Task PostsToCorrectUrl() { - var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name"); + var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name", false); var connection = Substitute.For<IApiConnection>(); var client = new PullRequestsClient(connection); @@ -249,7 +249,7 @@ public async Task PostsToCorrectUrl() [Fact] public async Task PostsToCorrectUrlWithRepositoryId() { - var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name"); + var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name", false); var connection = Substitute.For<IApiConnection>(); var client = new PullRequestsClient(connection); @@ -265,14 +265,14 @@ public async Task EnsuresNonNullArguments() var connection = Substitute.For<IApiConnection>(); var client = new PullRequestsClient(connection); - await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(null, "name", new NewPullRequest("title", "ref", "ref2"))); - await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", null, new NewPullRequest("title", "ref", "ref2"))); + await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(null, "name", new NewPullRequest("title", "ref", "ref2", false))); + await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", null, new NewPullRequest("title", "ref", "ref2", false))); await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", "name", null)); await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(1, null)); - await Assert.ThrowsAsync<ArgumentException>(() => client.Create("", "name", new NewPullRequest("title", "ref", "ref2"))); - await Assert.ThrowsAsync<ArgumentException>(() => client.Create("owner", "", new NewPullRequest("title", "ref", "ref2"))); + await Assert.ThrowsAsync<ArgumentException>(() => client.Create("", "name", new NewPullRequest("title", "ref", "ref2", false))); + await Assert.ThrowsAsync<ArgumentException>(() => client.Create("owner", "", new NewPullRequest("title", "ref", "ref2", false))); } } @@ -310,14 +310,14 @@ public async Task EnsuresNonNullArguments() var connection = Substitute.For<IApiConnection>(); var client = new PullRequestsClient(connection); - await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(null, "name", new NewPullRequest("title", "ref", "ref2"))); - await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", null, new NewPullRequest("title", "ref", "ref2"))); + await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(null, "name", new NewPullRequest("title", "ref", "ref2", false))); + await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", null, new NewPullRequest("title", "ref", "ref2", false))); await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create("owner", "name", null)); await Assert.ThrowsAsync<ArgumentNullException>(() => client.Create(1, null)); - await Assert.ThrowsAsync<ArgumentException>(() => client.Create("", "name", new NewPullRequest("title", "ref", "ref2"))); - await Assert.ThrowsAsync<ArgumentException>(() => client.Create("owner", "", new NewPullRequest("title", "ref", "ref2"))); + await Assert.ThrowsAsync<ArgumentException>(() => client.Create("", "name", new NewPullRequest("title", "ref", "ref2", false))); + await Assert.ThrowsAsync<ArgumentException>(() => client.Create("owner", "", new NewPullRequest("title", "ref", "ref2", false))); } } diff --git a/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs b/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs index 8ca0e56061..2e22b0e01b 100644 --- a/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs +++ b/Octokit.Tests/Reactive/ObservablePullRequestsClientTests.cs @@ -462,7 +462,7 @@ public class TheCreateMethod [Fact] public void CreatesFromClientRepositoryPullRequest() { - var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name"); + var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name", false); var gitHubClient = Substitute.For<IGitHubClient>(); var client = new ObservablePullRequestsClient(gitHubClient); @@ -474,7 +474,7 @@ public void CreatesFromClientRepositoryPullRequest() [Fact] public void CreatesFromClientRepositoryPullRequestWithRepositoryId() { - var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name"); + var newPullRequest = new NewPullRequest("some title", "branch:name", "branch:name", false); var gitHubClient = Substitute.For<IGitHubClient>(); var client = new ObservablePullRequestsClient(gitHubClient); @@ -489,14 +489,14 @@ public void EnsuresNonNullArguments() var gitHubClient = Substitute.For<IGitHubClient>(); var client = new ObservablePullRequestsClient(gitHubClient); - Assert.Throws<ArgumentNullException>(() => client.Create(null, "name", new NewPullRequest("title", "ref", "ref2"))); - Assert.Throws<ArgumentNullException>(() => client.Create("owner", null, new NewPullRequest("title", "ref", "ref2"))); + Assert.Throws<ArgumentNullException>(() => client.Create(null, "name", new NewPullRequest("title", "ref", "ref2", false))); + Assert.Throws<ArgumentNullException>(() => client.Create("owner", null, new NewPullRequest("title", "ref", "ref2", false))); Assert.Throws<ArgumentNullException>(() => client.Create("owner", "name", null)); Assert.Throws<ArgumentNullException>(() => client.Create(1, null)); - Assert.Throws<ArgumentException>(() => client.Create("", "name", new NewPullRequest("title", "ref", "ref2"))); - Assert.Throws<ArgumentException>(() => client.Create("owner", "", new NewPullRequest("title", "ref", "ref2"))); + Assert.Throws<ArgumentException>(() => client.Create("", "name", new NewPullRequest("title", "ref", "ref2", false))); + Assert.Throws<ArgumentException>(() => client.Create("owner", "", new NewPullRequest("title", "ref", "ref2", false))); } }