Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests fail on Node v18 #489

Closed
wolfy1339 opened this issue Jul 7, 2022 · 3 comments · Fixed by #546
Closed

Tests fail on Node v18 #489

wolfy1339 opened this issue Jul 7, 2022 · 3 comments · Fixed by #546
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR

Comments

@wolfy1339
Copy link
Member

FAIL test/agent-ca/agent-ca-test.test.ts
  ● custom client certificate › https.Agent({ca})
    error:0A00018E:SSL routines::ca md too weak
       9 |   let server: any;
      10 |   beforeAll((done) => {
    > 11 |     server = createServer(
         |              ^
      12 |       {
      13 |         key: readFileSync(resolve(__dirname, "./localhost.key")),
      14 |         cert: readFileSync(resolve(__dirname, "./localhost.crt")),
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/agent-ca/agent-ca-test.test.ts:11:14)
  ● custom client certificate › https.Agent({ca, rejectUnauthorized})
    error:0A00018E:SSL routines::ca md too weak
       9 |   let server: any;
      10 |   beforeAll((done) => {
    > 11 |     server = createServer(
         |              ^
      12 |       {
      13 |         key: readFileSync(resolve(__dirname, "./localhost.key")),
      14 |         cert: readFileSync(resolve(__dirname, "./localhost.crt")),
          at Array.forEach (<anonymous>)
      at Object.<anonymous> (test/agent-ca/agent-ca-test.test.ts:11:14)
  ● Test suite failed to run
    TypeError: Cannot read properties of undefined (reading 'close')
      53 |
      54 |   afterAll((done) => {
    > 55 |     server.close(done);
         |            ^
      56 |   });
      57 | });
      58 |
      at Object.<anonymous> (test/agent-ca/agent-ca-test.test.ts:55:12)
@wolfy1339 wolfy1339 added the Type: Bug Something isn't working as documented label Jul 7, 2022
@gr2m
Copy link
Contributor

gr2m commented Jul 8, 2022

I don't think this is a production bug, I think it's the self-signed certificates that no longer seem to be compatible with Node 18. I think this is a testing/maintenance issue, not a bug

@wolfy1339 wolfy1339 added Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR and removed Type: Bug Something isn't working as documented labels Jul 8, 2022
@wolfy1339
Copy link
Member Author

It seems we need to regenerate the certificates with a stronger cipher.

I believe it is related to NodeJS using OpenSSL 3.0 now
https://nodejs.org/en/blog/release/v17.0.0/#openssl-3-0

@github-actions
Copy link
Contributor

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Type: Maintenance Any dependency, housekeeping, and clean up Issue or PR
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants