Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: v7 introduced a ProxyAgent that is not supported in Bun #641

Closed
1 task done
rhuanbarreto opened this issue Sep 6, 2024 · 2 comments
Closed
1 task done
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented

Comments

@rhuanbarreto
Copy link

What happened?

I received a package upgrade PR to bump this package to v7. ONe of the breaking changes is the addition to get a ProxyAgent.

But ProxyAgent from undici is not yet supported in Bun: oven-sh/bun#4474

Versions

Octokit.js v7.0.0
Bun latest version

Relevant log output

SyntaxError: Import named 'ProxyAgent' not found in module 'undici'.

Code of Conduct

  • I agree to follow this project's Code of Conduct
@rhuanbarreto rhuanbarreto added Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented labels Sep 6, 2024
Copy link

github-actions bot commented Sep 6, 2024

👋 Hi! Thank you for this contribution! Just to let you know, our GitHub SDK team does a round of issue and PR reviews twice a week, every Monday and Friday! We have a process in place for prioritizing and responding to your input. Because you are a part of this community please feel free to comment, add to, or pick up any issues/PRs that are labeled with Status: Up for grabs. You & others like you are the reason all of this works! So thank you & happy coding! 🚀

@wolfy1339
Copy link
Member

The ProxyAgent wasn't a breaking change as the proxy functionality was already there in previous versions of the package.

We simply updated to use undici as that is what powers Node's fetch API.

We don't guarantee support for other platforms than Node.

There isn't anything actionable on our side.

@wolfy1339 wolfy1339 closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
@github-project-automation github-project-automation bot moved this from 🆕 Triage to ✅ Done in 🧰 Octokit Active Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Triage This is being looked at and prioritized Type: Bug Something isn't working as documented
Projects
Archived in project
Development

No branches or pull requests

2 participants