Replies: 1 comment 2 replies
-
Yeah, Also, I haven't gone through all the changes that you have mentioned, but we have to be careful about breaking changes, all of them will need to considered in v2.x.x to be compatible with SemVer. |
Beta Was this translation helpful? Give feedback.
2 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
In the 02/15/2022 Network Activity Sync, we uncovered several issues where this is room for improvement.
High Level - we considered that these changes would help align weblogs such as Apache Access logs better align with the
HTTP Activity class
, as web logs don't seem to fit very well under theAccess Activity
class.Some of these may or may not be breaking changes:
http_request.args (Optional String)
andhttp_request.url.query_string (Recommended String)
. It was suggested that at a minimumargs
be changed from a string to an array that has name/value pairs. Note: this would be a breaking change.url.text
andurl.hostname
fromRequired
toRecommended
.http_method
should be an enum of the various http methods. Note: this would be a breaking change.http_
is redundant forhttp_method
andhttp_header
. Suggestion, drop thehttp_
. Note: this would be a breaking change.dst_endpoint
fromRequired
toRecommended
, as they are not present in Apache logs and other web logs.referrer
a url object, rather than a string value. The reason is that it contains urls with host, path, and query string. Note: this would be a breaking change.Access Activity
class to thedev
extension. It looks like it needs some work. Note: is anyone yet using this?Beta Was this translation helpful? Give feedback.
All reactions