Skip to content

Commit cb522bc

Browse files
committed
updated contribution guidelines
1 parent 858e499 commit cb522bc

File tree

1 file changed

+39
-10
lines changed

1 file changed

+39
-10
lines changed

CONTRIBUTING.md

+39-10
Original file line numberDiff line numberDiff line change
@@ -1,26 +1,55 @@
11
# Contributing Guidelines
22

3-
Thank you for your interest in contributing to our project! We welcome contributions from the community to help improve our project and make it even better. Before you get started, please take a moment to review the following guidelines.
3+
Thank you for your interest in contributing to the QvikChat project! We welcome contributions from the community to help improve the project and make it even better. Before you get started, please take a moment to review the following guidelines.
44

55
## Getting Started
66

7-
To contribute to our project, please follow these steps:
7+
To contribute to the QvikChat project, please follow these steps:
88

99
1. Fork the repository.
10-
2. Create a new branch for your contribution.
11-
3. Make your changes or additions.
12-
4. Test your changes to ensure they work as expected.
13-
5. Commit your changes and push them to your forked repository.
14-
6. Submit a pull request to our main repository.
10+
11+
Click the "Fork" button at the top of the repository to create a copy of the project in your GitHub account.
12+
13+
2. Create a clone of the forked repository to add your changes to it.
14+
15+
Use the `git clone` command to create a local copy of your forked repository on your machine.
16+
17+
3. Create a new branch for your contribution.
18+
19+
Use the `git checkout -b` command to create a new branch and start making changes.
20+
21+
4. Make your changes or additions.
22+
5. Test your changes to ensure they work as expected.
23+
24+
You can use the `pnpm predeploy` command. This command will perform following in order: linting, code formatting, compilation and testing.
25+
26+
Testing may involve the use LLM model. So, you may have to setup environment variables correctly before being able to run tests locally. To learn more check [Setup Environment Variables](https://qvikchat.pkural.ca/getting-started#setup-environment-variables).
27+
28+
6. Commit your changes and push them to your forked repository.
29+
7. Submit a pull request to our main repository. Be sure to include a detailed description of your changes.
1530

1631
## Code Style
1732

18-
We follow a specific code style in our project to maintain consistency and readability. Please make sure to adhere to the following guidelines:
33+
Although not strictly, QvikChat follows the [Google TypeScript Style Guide](https://google.github.io/styleguide/tsguide.html) as much possible to maintain consistency and readability.
34+
35+
Once you are done with your changes, simply run the `pnpm lint` and `pnpm format` commands to ensure that your code is properly formatted and adheres to the style guide.
36+
37+
Please make sure to adhere to the following guidelines:
1938

2039
- Use meaningful variable and function names.
2140
- Indent code using spaces, not tabs. Use prettier to format your code if possible.
22-
- Use proper commenting to explain complex logic or algorithms.
2341
- Follow the naming conventions for files, classes, functions, and variables.
42+
- Use single quotes for strings.
43+
- Use kebab-case for file names and folder names.
44+
- Use camelCase for variable names and function names.
45+
46+
## Comments and Documentation
47+
48+
When contributing to the QvikChat project, please ensure that your code is well-documented and includes comments extensively. This will help other developers understand your code and make it easier to maintain in the future. Code changes without proper documentation may not be accepted.
49+
50+
## QvikChat Documentation
51+
52+
If you are contributing to the QvikChat project, please ensure that your changes are reflected in the official QvikChat documentation. Check the [qvikchat-docs repository](https://github.com/oconva/qvikchat-docs) for the documentation and make the necessary changes to reflect your contributions.
2453

2554
## Reporting Issues
2655

@@ -37,7 +66,7 @@ When submitting a pull request, please ensure the following:
3766
1. Provide a clear and descriptive title for your pull request.
3867
2. Include a detailed description of the changes you have made.
3968
3. Reference any related issues or pull requests.
40-
4. Make sure your code passes all tests and doesn't introduce any new issues.
69+
4. Make sure your code passes all tests and status checks.
4170
5. Keep your pull request focused on a single feature or bug fix.
4271

4372
## Code of Conduct

0 commit comments

Comments
 (0)