Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup test coverage reporting #214

Closed
alexcos20 opened this issue Aug 18, 2020 · 1 comment · Fixed by #252
Closed

Setup test coverage reporting #214

alexcos20 opened this issue Aug 18, 2020 · 1 comment · Fixed by #252

Comments

@alexcos20
Copy link
Member

No description provided.

@kremalicious
Copy link
Contributor

Not exactly clear what this entails but noticing that almost all unit tests:

  • are commented out
  • are written in a way which makes them not just unit tests
  • bunch of them were not run because of path globbing (see 31bec3c)

They always get the full ocean instance, but for the unit tests we should rather import the classes directly into its respective test file. Doing it that way would already allow us to run more of the commented-out tests because I think that is why they were commented out, not being able to initiate Ocean in unit tests.

And to get visibility into test coverage we should have:

  • coverage report for unit tests
  • coverage report for integration test
  • setup CodeClimate
  • on Travis, combine both coverage reports into one and send to CodeClimate

@kremalicious kremalicious changed the title Fuzz tests Setup test coverage, bring to >80% Sep 3, 2020
@kremalicious kremalicious changed the title Setup test coverage, bring to >80% Setup test coverage reporting, bring to >80% Sep 3, 2020
@kremalicious kremalicious changed the title Setup test coverage reporting, bring to >80% Setup test coverage reporting Sep 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants