Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide outdated / old / redundant assets #445

Closed
kaimeinke opened this issue Mar 18, 2021 · 6 comments
Closed

Hide outdated / old / redundant assets #445

kaimeinke opened this issue Mar 18, 2021 · 6 comments
Labels
Type: Enhancement New feature or request

Comments

@kaimeinke
Copy link

As discussed with @trentmc during the last DAO town hall meeting I would like to request to hide a dataset / data service from the market interface once it is outdated or migrated to another chain.

This would require the same functionality as for the purgatory with slight modifications:

a. The publisher should not be put into purgatory
b. There should not be any attribution to purgatory because this would impact the reputation of the publisher

This feature would be all about cleaning the marketplace interface up and allow for better visibility of "good" datasets and -services.

I would request to hide i.e. this one: https://market.oceanprotocol.com/asset/did:op:10b1CfF754bE22181a5bE5c2825F1bBC56473DFE

It has been created and due to an error in the process it has been made obsolute by creating a new dataset.

In my opinion it is necessary, that publishers and LPs and token holders still have the option to interact with "hidden" pools as they might want to remove the last bit of liquidity later on.

Looking forward to a discussion and implementation.

@kaimeinke kaimeinke added the Type: Enhancement New feature or request label Mar 18, 2021
@trentmc
Copy link
Member

trentmc commented Mar 19, 2021

Thanks for documenting this, Kai.

@kaimeinke
Copy link
Author

I followed the discussion in #452 and I would like to add that this "unlist" feature might get additional priority due to regulatory concerns. During April and May the German Authorities are working on a new law regarding tokenized assets. This might lead to the need to unlist assets that do not comply with regulatory requirements. I would love to have this feature rather sooner than later.

@alexcos20
Copy link
Member

what happens when there is pool and people have liquidity ? if we "retire" the asset, it's not going to be visible.

@kaimeinke
Copy link
Author

kaimeinke commented Apr 19, 2021

This could work as in purgatory. All people invested in it can still access it and remove liquidity, but interactions from new participants would be impossible.

But I see a problem with people actually owning datatokens and do not know if they are actually able to interact with / discover a dataset in purgatory right now. Those have datatokens should have the option to change them to liquidity / get rid of their tokens.

@kremalicious
Copy link
Contributor

kremalicious commented Nov 30, 2021

This can be revisited with v4, as the Data NFT includes a new state field, set by publisher defining the state of the asset. See https://github.com/oceanprotocol/docs/blob/feature/ddo_v4/content/concepts/did-ddo.md#state for current draft.

Still pending to be defined which component does what with which state.

@mihaisc
Copy link
Contributor

mihaisc commented Jul 13, 2022

https://docs.oceanprotocol.com/concepts/did-ddo/#state Updating the state to 1,2,3 will remove the asset from Aquarius

@mihaisc mihaisc closed this as completed Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants