Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue: num_decimals = 0, should be 18 #111

Closed
trentmc opened this issue Jun 18, 2020 · 0 comments · Fixed by #112
Closed

Fix issue: num_decimals = 0, should be 18 #111

trentmc opened this issue Jun 18, 2020 · 0 comments · Fixed by #112
Assignees
Labels
Type: Bug Something isn't working

Comments

@trentmc
Copy link
Member

trentmc commented Jun 18, 2020

DataTokenTemplate.sol needs decimals to be able to support AMMs like Balancer and Uniswap. Balancer is currently the leading contender to make marketplace non-custodial and to support marketplace incentives. I encountered this issue first hand this week while doing Balancer experiments (I did a workaround in my branch by fudging the file to 18 decimals). Details of why are in this V3 slide.

I recommend 18 decimals because that's what ETH and OCEAN have (as most other tokens). It allows library conversion commands fromWei() and toWei().

@trentmc trentmc added the Type: Bug Something isn't working label Jun 18, 2020
@0x3bfc 0x3bfc mentioned this issue Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants