Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connection to server still made even if "automatically check for updates" is disabled #4044

Closed
dot-gov opened this issue Jan 9, 2021 · 8 comments
Labels

Comments

@dot-gov
Copy link

dot-gov commented Jan 9, 2021

Platform

Operating system and version: Windows 10
OBS Studio version: 26.1.1

Expected Behavior

No connections to OBS servers made

Current Behavior

Connection is made to obsproject.com to download the following urls:
https://obsproject.com/update_studio/whatsnew.json
https://obsproject.com/obs2_update/rtmp-services/package.json

Steps to Reproduce

  1. Install OBS
  2. Launch OBS
  3. Open settings (file -> settings -> general), uncheck "automatically check for updates on startup"
  4. Save settings
  5. Restart OBS

Additional information

The request to https://obsproject.com/update_studio/whatsnew.json also contains a "X-OBS2-GUID" header, which appears to be an installation identifier. Presumably this is used as telemetry to keep track of how many installations are there and how often they're used (since the request is made every time OBS launches).

@WizardCM
Copy link
Member

WizardCM commented Jan 9, 2021

"What's new" is separate from the updater - it has the ability to display a webpage on launch, for example to allow us to notify users about an issue with their version. We just don't do it much.

@WizardCM WizardCM closed this as completed Jan 9, 2021
@Fenrirthviti
Copy link
Member

Going to reopen this for further comment, in case there are any additional concerns on this.

@Fenrirthviti Fenrirthviti reopened this Jan 9, 2021
@Fenrirthviti
Copy link
Member

To clarify a few things, there's actually 3 current "update" checks with OBS, and the checkbox in settings only manages one of those.

  • https://obsproject.com/obs2_update/rtmp-services/package.json is the streaming services list, which populates Settings -> Stream. This update check allows us to push service updates without needing to do a full release.
  • https://obsproject.com/update_studio/whatsnew.json is a "notification" system that we implemented, but rarely ended up using. It simply will display a web-page as an in-application panel to the user when we deem it necessary to send that kind of notification out-of-band of the normal update process.
  • The normal OBS version update check, which is only active on Windows and macOS versions.

While these do send a GUID to us, they are not typically used for any kind of telemetry or tracking currently, outside a general baseline of "how many people use OBS" that we sometimes run a report against. They are not intended for telemetry or tracking, but I can understand the concerns here. I agree that the "check for updates" checkbox is a little ambiguous, it should actually read something like "Check for OBS version updates" instead, as the services and announcement checks are separate to that function entirely.

@mufunyo
Copy link

mufunyo commented Jan 9, 2021

Maybe an option could be made to disable any sort of "calling home", accessible only by editing the ini file. I'd argue it's super niche to want it but also fair to include.

@dot-gov
Copy link
Author

dot-gov commented Jan 10, 2021

The other privacy preserving option (that doesn't compromise usability) would be an option to disable sending the X-OBS2-GUID header.

@mufunyo
Copy link

mufunyo commented Jan 11, 2021

The other privacy preserving option (that doesn't compromise usability) would be an option to disable sending the X-OBS2-GUID header.

That still exposes IP address and date/time metadata.

@WizardCM WizardCM changed the title Connection to update server still made even if "automatically check for updates" is disabled Connection to server still made even if "automatically check for updates" is disabled Mar 2, 2021
@Bryophyt3
Copy link

This would also be desired for stability and reliability, i.e. a way to prevent the dreaded ""OBS update broke my stream" issue, which has gained widespread notoriety.

@Fenrirthviti
Copy link
Member

While I understand and acknowledge the privacy concern here, I think it's reasonable to assume that anyone concerned about outbound connections from a privacy standpoint will already have basic firewall rules in place to block outbound traffic unless explicitly allowed.

We may revisit this at some point, but going to close this for now.

@Fenrirthviti Fenrirthviti closed this as not planned Won't fix, can't repro, duplicate, stale Oct 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants