Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add DataPlane https injestion for SecOps exporter #1829

Merged
merged 4 commits into from
Sep 4, 2024
Merged

feat: Add DataPlane https injestion for SecOps exporter #1829

merged 4 commits into from
Sep 4, 2024

Conversation

shazlehu
Copy link
Contributor

@shazlehu shazlehu commented Aug 29, 2024 •
edited
Loading

Proposed Change

Adds support for the new DataPlane REST injestion API for SecOps.

Refer to bindplane PR https://github.com/observIQ/bindplane-op-enterprise/pull/3443 for testing setup.

Checklist
  • Changes are tested
  • CI has passed

@shazlehu shazlehu force-pushed the samhazlehurst/bpop-663-add-http-exporter-to-secops branch 6 times, most recently from 357673f to eadc0a8 Compare August 30, 2024 18:46
@shazlehu shazlehu changed the title Add DataPlane https injestion for secops exporter feat: Add DataPlane https injestion for SecOps exporter Aug 30, 2024
dpaasman00
dpaasman00 requested changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@dpaasman00 dpaasman00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First pass looks good

@shazlehu shazlehu force-pushed the samhazlehurst/bpop-663-add-http-exporter-to-secops branch from eadc0a8 to 36026dd Compare September 4, 2024 12:29
@shazlehu shazlehu requested a review from dpaasman00 September 4, 2024 12:31
@shazlehu shazlehu changed the base branch from release/v1.59.0 to release/v1.60.0 September 4, 2024 13:12
dpaasman00
dpaasman00 requested changes Sep 4, 2024
View reviewed changes
Copy link
Contributor

@dpaasman00 dpaasman00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and is working well for me.

Minor nit to add a more informative comment to lingering TODOs about why we're waiting/what we're waiting for

@shazlehu shazlehu force-pushed the samhazlehurst/bpop-663-add-http-exporter-to-secops branch from a7b058f to d075a42 Compare September 4, 2024 18:41
@shazlehu shazlehu force-pushed the samhazlehurst/bpop-663-add-http-exporter-to-secops branch from d075a42 to 5bf2002 Compare September 4, 2024 19:23
@shazlehu shazlehu merged commit ac967d5 into release/v1.60.0 Sep 4, 2024
15 checks passed
@shazlehu shazlehu deleted the samhazlehurst/bpop-663-add-http-exporter-to-secops branch September 4, 2024 20:35
dpaasman00 pushed a commit that referenced this pull request Sep 17, 2024
@shazlehu @dpaasman00
feat: Add DataPlane https injestion for SecOps exporter (#1829)
117ba15 
* Add DataPlane https injestion for secops exporter
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dpaasman00 dpaasman00 dpaasman00 approved these changes

@BinaryFissionGames BinaryFissionGames Awaiting requested review from BinaryFissionGames

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shazlehu @dpaasman00