Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support scripts for gathering os info, collector logs and collector config #1111

Merged
merged 15 commits into from
Jun 14, 2023
Merged

feat: Support scripts for gathering os info, collector logs and collector config #1111

merged 15 commits into from
Jun 14, 2023

Conversation

shazlehu
Copy link
Contributor

@shazlehu shazlehu commented Jun 6, 2023

Proposed Change

Linux and Windows scripts for collecting os info and the collector's log files and configuration file

Checklist
  • Changes are tested
  • CI has passed

@shazlehu shazlehu requested a review from a team as a code owner June 6, 2023 15:22
@CLAassistant
Copy link

CLAassistant commented Jun 6, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

cpheps
cpheps reviewed Jun 6, 2023
View reviewed changes
Copy link
Contributor

@cpheps cpheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tried this yet the overall approach looks good. The scripts don't feel uniform, mostly linux vs windows, but I'm not sure if that matters.

BinaryFissionGames
BinaryFissionGames reviewed Jun 6, 2023
View reviewed changes
shazlehu and others added 2 commits June 6, 2023 15:42
@shazlehu
Added observiq_collector.err collection and use Windows registry to f…
4b91586 
…ind collector installation directory
@shazlehu @BinaryFissionGames
Update scripts/support/create-support-bundle.sh
cff8c21 
Co-authored-by: Brandon Johnson <brandon.johnson@bluemedora.com>
cpheps
cpheps suggested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@cpheps cpheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Powershell script works great. Batch script is good but would be nice if it created a zip. Linux script created an odd structure in the resulting tar.

cpheps
cpheps suggested changes Jun 7, 2023
View reviewed changes
Copy link
Contributor

@cpheps cpheps left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linux script is working great just need to tweak permissions I think.

@cpheps
Copy link
Contributor

cpheps commented Jun 7, 2023

We likely need some sort of documentation in the docs folder on how to use this so the support team can have a reference.

cpheps
cpheps reviewed Jun 8, 2023
View reviewed changes
shazlehu and others added 3 commits June 8, 2023 09:56
@shazlehu
Update docs/create-support-bundle.md
65d7391 
Co-authored-by: Corbin Phelps <corbin.phelps@bluemedora.com>
@shazlehu
Added link to readme, journalctl output to linux script, changed conf…
9f3a505 
…ig.yaml question to default to yes
@shazlehu
Merge
4ca23a2
@shazlehu @BinaryFissionGames
Update scripts/support/create-support-bundle.bat
86ab16b 
Co-authored-by: Brandon Johnson <brandon.johnson@bluemedora.com>
@BinaryFissionGames BinaryFissionGames self-requested a review June 8, 2023 14:51
@BinaryFissionGames BinaryFissionGames merged commit e7f4330 into release/v1.27.0 Jun 14, 2023
@BinaryFissionGames BinaryFissionGames deleted the feature/support-bundle-scripts branch June 14, 2023 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BinaryFissionGames BinaryFissionGames BinaryFissionGames approved these changes

@cpheps cpheps cpheps approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shazlehu @CLAassistant @cpheps @BinaryFissionGames