From 5770013799418a98f54a27300f5599dfc1601c8c Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Tue, 7 Jan 2025 07:46:13 -0600
Subject: [PATCH 01/10] Changed the comment boxes to single line, expanding to
 4 and changed the required title to use a red asterisk.

---
 web-ui/src/components/pulse/Pulse.css | 4 ++++
 web-ui/src/components/pulse/Pulse.jsx | 7 +++++--
 web-ui/src/pages/PulsePage.jsx        | 3 ++-
 3 files changed, 11 insertions(+), 3 deletions(-)

diff --git a/web-ui/src/components/pulse/Pulse.css b/web-ui/src/components/pulse/Pulse.css
index 4fc7240f9e..fb73042e5a 100644
--- a/web-ui/src/components/pulse/Pulse.css
+++ b/web-ui/src/components/pulse/Pulse.css
@@ -20,6 +20,10 @@
     margin-bottom: 1rem;
     padding: 1rem;
   }
+
+  .title-row {
+    display: flex;
+  }
 }
 
 :root[data-mui-color-scheme='dark'] {
diff --git a/web-ui/src/components/pulse/Pulse.jsx b/web-ui/src/components/pulse/Pulse.jsx
index 379942c6d8..3382d8313d 100644
--- a/web-ui/src/components/pulse/Pulse.jsx
+++ b/web-ui/src/components/pulse/Pulse.jsx
@@ -44,7 +44,10 @@ const Pulse = ({
   title
 }) => (
   <div className="pulse">
-    <Typography variant="h6">{title}</Typography>
+    <div className="title-row">
+      <Typography variant="h6">{title}</Typography>
+      {commentRequired && <Typography variant="h6" color="red">*</Typography>}
+    </div>
     <div className="icon-row">
       {icons.map((sentiment, index) => (
         <Tooltip key={`sentiment-${index}`} title={tooltips[index]} arrow>
@@ -70,7 +73,7 @@ const Pulse = ({
       }}
       placeholder="Comment"
       required={commentRequired}
-      rows={4}
+      maxRows={4}
       value={comment}
     />
   </div>
diff --git a/web-ui/src/pages/PulsePage.jsx b/web-ui/src/pages/PulsePage.jsx
index ef6877f019..67fab04e83 100644
--- a/web-ui/src/pages/PulsePage.jsx
+++ b/web-ui/src/pages/PulsePage.jsx
@@ -120,10 +120,11 @@ const PulsePage = () => {
           <Pulse
             key="pulse-internal"
             comment={internalComment}
+            commentRequired={true}
             score={internalScore}
             setComment={setInternalComment}
             setScore={setInternalScore}
-            title="How are you feeling about work today? (*)"
+            title="How are you feeling about work today?"
           />
           <Pulse
             key="pulse-external"

From 34a5f1c3c830ed3e2b6f03a7f81ea4a366502805 Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Tue, 7 Jan 2025 08:06:03 -0600
Subject: [PATCH 02/10] Updated test snapshots.

---
 .../pulse/__snapshots__/Pulse.test.jsx.snap   | 13 +++---
 .../__snapshots__/PulsePage.test.jsx.snap     | 43 ++++++++++++++-----
 2 files changed, 40 insertions(+), 16 deletions(-)

diff --git a/web-ui/src/components/pulse/__snapshots__/Pulse.test.jsx.snap b/web-ui/src/components/pulse/__snapshots__/Pulse.test.jsx.snap
index 63e99f560f..663e3ad4d4 100644
--- a/web-ui/src/components/pulse/__snapshots__/Pulse.test.jsx.snap
+++ b/web-ui/src/components/pulse/__snapshots__/Pulse.test.jsx.snap
@@ -6,11 +6,15 @@ exports[`renders correctly 1`] = `
     <div
       class="pulse"
     >
-      <h6
-        class="MuiTypography-root MuiTypography-h6 css-2ulfj5-MuiTypography-root"
+      <div
+        class="title-row"
       >
-        How are you feeling about work today? (*)
-      </h6>
+        <h6
+          class="MuiTypography-root MuiTypography-h6 css-2ulfj5-MuiTypography-root"
+        >
+          How are you feeling about work today? (*)
+        </h6>
+      </div>
       <div
         class="icon-row"
       >
@@ -203,7 +207,6 @@ exports[`renders correctly 1`] = `
             class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputMultiline css-1sqnrkk-MuiInputBase-input-MuiOutlinedInput-input"
             id=":r5:"
             placeholder="Comment"
-            rows="4"
             style="height: 0px; overflow: hidden;"
           >
             Just testing
diff --git a/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap b/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap
index f433cc329b..55bdddcf1c 100644
--- a/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap
+++ b/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap
@@ -8,11 +8,20 @@ exports[`renders correctly 1`] = `
     <div
       class="pulse"
     >
-      <h6
-        class="MuiTypography-root MuiTypography-h6 css-2ulfj5-MuiTypography-root"
+      <div
+        class="title-row"
       >
-        How are you feeling about work today? (*)
-      </h6>
+        <h6
+          class="MuiTypography-root MuiTypography-h6 css-2ulfj5-MuiTypography-root"
+        >
+          How are you feeling about work today?
+        </h6>
+        <h6
+          class="MuiTypography-root MuiTypography-h6 css-1i2vuon-MuiTypography-root"
+        >
+          *
+        </h6>
+      </div>
       <div
         class="icon-row"
       >
@@ -190,12 +199,19 @@ exports[`renders correctly 1`] = `
         data-testid="comment-input"
       >
         <label
-          class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined MuiFormLabel-colorPrimary MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined css-14s5rfu-MuiFormLabel-root-MuiInputLabel-root"
+          class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined MuiFormLabel-colorPrimary Mui-required MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined css-14s5rfu-MuiFormLabel-root-MuiInputLabel-root"
           data-shrink="false"
           for=":r5:"
           id=":r5:-label"
         >
           Comment
+          <span
+            aria-hidden="true"
+            class="MuiFormLabel-asterisk MuiInputLabel-asterisk css-wgai2y-MuiFormLabel-asterisk"
+          >
+             
+            *
+          </span>
         </label>
         <div
           class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-multiline css-8ewcdo-MuiInputBase-root-MuiOutlinedInput-root"
@@ -205,7 +221,7 @@ exports[`renders correctly 1`] = `
             class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputMultiline css-1sqnrkk-MuiInputBase-input-MuiOutlinedInput-input"
             id=":r5:"
             placeholder="Comment"
-            rows="4"
+            required=""
             style="height: 0px; overflow: hidden;"
           />
           <textarea
@@ -224,6 +240,8 @@ exports[`renders correctly 1`] = `
             >
               <span>
                 Comment
+                 
+                *
               </span>
             </legend>
           </fieldset>
@@ -233,11 +251,15 @@ exports[`renders correctly 1`] = `
     <div
       class="pulse"
     >
-      <h6
-        class="MuiTypography-root MuiTypography-h6 css-2ulfj5-MuiTypography-root"
+      <div
+        class="title-row"
       >
-        How are you feeling about life outside of work?
-      </h6>
+        <h6
+          class="MuiTypography-root MuiTypography-h6 css-2ulfj5-MuiTypography-root"
+        >
+          How are you feeling about life outside of work?
+        </h6>
+      </div>
       <div
         class="icon-row"
       >
@@ -430,7 +452,6 @@ exports[`renders correctly 1`] = `
             class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputMultiline css-1sqnrkk-MuiInputBase-input-MuiOutlinedInput-input"
             id=":rb:"
             placeholder="Comment"
-            rows="4"
             style="height: 0px; overflow: hidden;"
           />
           <textarea

From 6817a6f0ce80aa371168972d2439ef6f54d2be17 Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Tue, 7 Jan 2025 09:57:15 -0600
Subject: [PATCH 03/10] Added a property to show that the icon is required and
 changed to allow de-selecting a smiley face.

---
 web-ui/src/components/pulse/Pulse.jsx | 6 ++++--
 web-ui/src/pages/PulsePage.jsx        | 3 ++-
 2 files changed, 6 insertions(+), 3 deletions(-)

diff --git a/web-ui/src/components/pulse/Pulse.jsx b/web-ui/src/components/pulse/Pulse.jsx
index 3382d8313d..9fc22ad32f 100644
--- a/web-ui/src/components/pulse/Pulse.jsx
+++ b/web-ui/src/components/pulse/Pulse.jsx
@@ -30,6 +30,7 @@ const tooltips = [
 const propTypes = {
   comment: PropTypes.string,
   commentRequired: PropTypes.bool,
+  iconRequired: PropTypes.bool,
   score: PropTypes.number,
   setComment: PropTypes.func,
   setScore: PropTypes.func,
@@ -38,6 +39,7 @@ const propTypes = {
 const Pulse = ({
   comment,
   commentRequired,
+  iconRequired,
   score,
   setComment,
   setScore,
@@ -46,7 +48,7 @@ const Pulse = ({
   <div className="pulse">
     <div className="title-row">
       <Typography variant="h6">{title}</Typography>
-      {commentRequired && <Typography variant="h6" color="red">*</Typography>}
+      {iconRequired && <Typography variant="h6" color="red">*</Typography>}
     </div>
     <div className="icon-row">
       {icons.map((sentiment, index) => (
@@ -55,7 +57,7 @@ const Pulse = ({
             aria-label="sentiment"
             className={index === score ? 'selected' : ''}
             data-testid={`score-button-${index}`}
-            onClick={() => setScore(index)}
+            onClick={() => setScore(score == index ? null : index)}
             sx={{ color: colors[index] }}
           >
             {sentiment}
diff --git a/web-ui/src/pages/PulsePage.jsx b/web-ui/src/pages/PulsePage.jsx
index 67fab04e83..683852740d 100644
--- a/web-ui/src/pages/PulsePage.jsx
+++ b/web-ui/src/pages/PulsePage.jsx
@@ -120,7 +120,7 @@ const PulsePage = () => {
           <Pulse
             key="pulse-internal"
             comment={internalComment}
-            commentRequired={true}
+            iconRequired={true}
             score={internalScore}
             setComment={setInternalComment}
             setScore={setInternalScore}
@@ -138,6 +138,7 @@ const PulsePage = () => {
             <Button
               style={{ marginTop: 0 }}
               onClick={submit}
+              disabled={internalScore == null}
               variant="contained">
               Submit
             </Button>

From c76a4c2a4293b419aea5f0d3b11dc2d47a2cc1ed Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Tue, 7 Jan 2025 10:54:48 -0600
Subject: [PATCH 04/10] No longer load the previous pulse.

---
 web-ui/src/pages/PulsePage.jsx | 35 +---------------------------------
 1 file changed, 1 insertion(+), 34 deletions(-)

diff --git a/web-ui/src/pages/PulsePage.jsx b/web-ui/src/pages/PulsePage.jsx
index 683852740d..938368d352 100644
--- a/web-ui/src/pages/PulsePage.jsx
+++ b/web-ui/src/pages/PulsePage.jsx
@@ -3,7 +3,7 @@ import { format } from 'date-fns';
 import React, { useContext, useEffect, useState } from 'react';
 import { useHistory } from 'react-router-dom';
 import { Button, Checkbox, Typography } from '@mui/material';
-import { downloadData, initiate } from '../api/generic.js';
+import { initiate } from '../api/generic.js';
 import Pulse from '../components/pulse/Pulse.jsx';
 import { AppContext } from '../context/AppContext';
 import { selectCsrfToken, selectCurrentUser } from '../context/selectors';
@@ -54,39 +54,6 @@ const PulsePage = () => {
                        center : pulse.externalScore - 1);
   }, [pulse]);
 
-  const loadTodayPulse = async () => {
-    if (!csrf || !currentUser?.id) return;
-
-    const query = {
-      dateFrom: today,
-      dateTo: today,
-      teamMemberId: currentUser.id
-    };
-
-    const res = await downloadData(pulseURL, csrf, query);
-    if (res.error) return;
-
-    // Sort pulse responses by date, latest to earliest
-    const pulses = res.payload.data?.sort((a, b) => {
-      const l = a.submissionDate;
-      const r = b.submissionDate;
-      if (r[0] == l[0]) {
-        if (r[1] == l[1]) {
-          return r[2] - l[2];
-        } else {
-          return r[1] - l[1];
-        }
-      } else {
-        return r[0] - l[0];
-      }
-    });
-    setPulse(pulses.at(0));
-  };
-
-  useEffect(() => {
-    loadTodayPulse();
-  }, [csrf, currentUser]);
-
   const submit = async () => {
     const myId = currentUser?.id;
     const data = {

From b4a0a635603006f5dc9168dc9e6260efa0dcfe36 Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Tue, 7 Jan 2025 11:00:55 -0600
Subject: [PATCH 05/10] Updated test snapshot

---
 .../src/pages/__snapshots__/PulsePage.test.jsx.snap  | 12 +-----------
 1 file changed, 1 insertion(+), 11 deletions(-)

diff --git a/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap b/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap
index 55bdddcf1c..5ed6cca6d9 100644
--- a/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap
+++ b/web-ui/src/pages/__snapshots__/PulsePage.test.jsx.snap
@@ -199,19 +199,12 @@ exports[`renders correctly 1`] = `
         data-testid="comment-input"
       >
         <label
-          class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined MuiFormLabel-colorPrimary Mui-required MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined css-14s5rfu-MuiFormLabel-root-MuiInputLabel-root"
+          class="MuiFormLabel-root MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined MuiFormLabel-colorPrimary MuiInputLabel-root MuiInputLabel-formControl MuiInputLabel-animated MuiInputLabel-sizeMedium MuiInputLabel-outlined css-14s5rfu-MuiFormLabel-root-MuiInputLabel-root"
           data-shrink="false"
           for=":r5:"
           id=":r5:-label"
         >
           Comment
-          <span
-            aria-hidden="true"
-            class="MuiFormLabel-asterisk MuiInputLabel-asterisk css-wgai2y-MuiFormLabel-asterisk"
-          >
-             
-            *
-          </span>
         </label>
         <div
           class="MuiInputBase-root MuiOutlinedInput-root MuiInputBase-colorPrimary MuiInputBase-fullWidth MuiInputBase-formControl MuiInputBase-multiline css-8ewcdo-MuiInputBase-root-MuiOutlinedInput-root"
@@ -221,7 +214,6 @@ exports[`renders correctly 1`] = `
             class="MuiInputBase-input MuiOutlinedInput-input MuiInputBase-inputMultiline css-1sqnrkk-MuiInputBase-input-MuiOutlinedInput-input"
             id=":r5:"
             placeholder="Comment"
-            required=""
             style="height: 0px; overflow: hidden;"
           />
           <textarea
@@ -240,8 +232,6 @@ exports[`renders correctly 1`] = `
             >
               <span>
                 Comment
-                 
-                *
               </span>
             </legend>
           </fieldset>

From bee62c548cfda03ae77223e91cd915b24f3d2704 Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Wed, 8 Jan 2025 11:02:53 -0600
Subject: [PATCH 06/10] Specify memberIds to download so that the "include
 terminated members" checkbox is honored.

---
 web-ui/src/components/admin/users/Users.jsx | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/web-ui/src/components/admin/users/Users.jsx b/web-ui/src/components/admin/users/Users.jsx
index e55ffc8d1b..9692289567 100644
--- a/web-ui/src/components/admin/users/Users.jsx
+++ b/web-ui/src/components/admin/users/Users.jsx
@@ -10,7 +10,7 @@ import AdminMemberCard from '../../member-directory/AdminMemberCard';
 import MemberModal from '../../member-directory/MemberModal';
 import {
   createMember,
-  reportAllMembersCsv
+  reportSelectedMembersCsv
 } from '../../../api/member';
 import { AppContext } from '../../../context/AppContext';
 import { UPDATE_MEMBER_PROFILES, UPDATE_TOAST } from '../../../context/actions';
@@ -110,7 +110,8 @@ const Users = () => {
   });
 
   const downloadMembers = async () => {
-    let res = await reportAllMembersCsv(csrf);
+    const res = await reportSelectedMembersCsv(
+                        normalizedMembers.map((m) => m.id), csrf);
     if (res?.error) {
       dispatch({
         type: UPDATE_TOAST,

From ac12385bfb637c00d8dfeea15863b3437b5c15f5 Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Wed, 8 Jan 2025 11:35:58 -0600
Subject: [PATCH 07/10] Default the event organization to an empty string
 instead of Unknown.

---
 web-ui/src/components/volunteer/VolunteerEvents.jsx | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/web-ui/src/components/volunteer/VolunteerEvents.jsx b/web-ui/src/components/volunteer/VolunteerEvents.jsx
index 66256fda76..92a12f58d6 100644
--- a/web-ui/src/components/volunteer/VolunteerEvents.jsx
+++ b/web-ui/src/components/volunteer/VolunteerEvents.jsx
@@ -258,7 +258,7 @@ const VolunteerEvents = ({ forceUpdate = () => {}, onlyMe = false }) => {
         <Autocomplete
           disableClearable
           getOptionLabel={(option) => 
-            option === 'new' ? 'Create a New Organization' : (relationshipMap[option]?.organizationId && organizationMap[relationshipMap[option].organizationId]?.name) || 'Unknown'
+            option === 'new' ? 'Create a New Organization' : (relationshipMap[option]?.organizationId && organizationMap[relationshipMap[option].organizationId]?.name) || ''
           }
           options={['new', ...relationships.filter((rel) => !rel.endDate).map((rel) => rel.id)]} // Use relationship IDs
           onChange={(event, value) => {

From c3b3da0fd8a654f578732ee6a1b9ff99d65a7b5e Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Thu, 9 Jan 2025 11:26:36 -0600
Subject: [PATCH 08/10] We still need to load today's pulse to ensure only a
 single submission per day, just don't fill in the response data.

---
 web-ui/src/pages/PulsePage.jsx | 46 ++++++++++++++++++++++++++--------
 1 file changed, 36 insertions(+), 10 deletions(-)

diff --git a/web-ui/src/pages/PulsePage.jsx b/web-ui/src/pages/PulsePage.jsx
index 938368d352..3690410e25 100644
--- a/web-ui/src/pages/PulsePage.jsx
+++ b/web-ui/src/pages/PulsePage.jsx
@@ -3,7 +3,7 @@ import { format } from 'date-fns';
 import React, { useContext, useEffect, useState } from 'react';
 import { useHistory } from 'react-router-dom';
 import { Button, Checkbox, Typography } from '@mui/material';
-import { initiate } from '../api/generic.js';
+import { downloadData, initiate } from '../api/generic.js';
 import Pulse from '../components/pulse/Pulse.jsx';
 import { AppContext } from '../context/AppContext';
 import { selectCsrfToken, selectCurrentUser } from '../context/selectors';
@@ -42,18 +42,44 @@ const PulsePage = () => {
     const [year, month, day] = pulse.submissionDate;
     setSubmittedToday(
       year === now.getFullYear() &&
-        month === now.getMonth() + 1 &&
-        day === now.getDate()
+      month === now.getMonth() + 1 &&
+      day === now.getDate()
     );
-
-    setInternalComment(pulse.internalFeelings ?? '');
-    setExternalComment(pulse.externalFeelings ?? '');
-    setInternalScore(pulse.internalScore == undefined ?
-                       center : pulse.internalScore - 1);
-    setExternalScore(pulse.externalScore == undefined ?
-                       center : pulse.externalScore - 1);
   }, [pulse]);
 
+  const loadTodayPulse = async () => {
+    if (!csrf || !currentUser?.id) return;
+
+    const query = {
+      dateFrom: today,
+      dateTo: today,
+      teamMemberId: currentUser.id
+    };
+
+    const res = await downloadData(pulseURL, csrf, query);
+    if (res.error) return;
+
+    // Sort pulse responses by date, latest to earliest
+    const pulses = res.payload.data?.sort((a, b) => {
+      const l = a.submissionDate;
+      const r = b.submissionDate;
+      if (r[0] == l[0]) {
+        if (r[1] == l[1]) {
+          return r[2] - l[2];
+        } else {
+          return r[1] - l[1];
+        }
+      } else {
+        return r[0] - l[0];
+      }
+    });
+    setPulse(pulses.at(0));
+  };
+
+  useEffect(() => {
+    loadTodayPulse();
+  }, [csrf, currentUser]);
+
   const submit = async () => {
     const myId = currentUser?.id;
     const data = {

From a80c49bb451d8a7b26982386b3e9fee86efe7452 Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Thu, 9 Jan 2025 13:25:34 -0600
Subject: [PATCH 09/10] Send null for externalScore if not provided and handle
 null extern score values in the pulse report.

---
 web-ui/src/pages/PulsePage.jsx       | 2 +-
 web-ui/src/pages/PulseReportPage.jsx | 8 ++++++--
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git a/web-ui/src/pages/PulsePage.jsx b/web-ui/src/pages/PulsePage.jsx
index 3690410e25..e9a247c1cf 100644
--- a/web-ui/src/pages/PulsePage.jsx
+++ b/web-ui/src/pages/PulsePage.jsx
@@ -84,7 +84,7 @@ const PulsePage = () => {
     const myId = currentUser?.id;
     const data = {
       externalFeelings: externalComment,
-      externalScore: externalScore + 1, // converts to 1-based
+      externalScore: externalScore == null ? null : externalScore + 1, // converts to 1-based
       internalFeelings: internalComment,
       internalScore: internalScore + 1, // converts to 1-based
       submissionDate: today,
diff --git a/web-ui/src/pages/PulseReportPage.jsx b/web-ui/src/pages/PulseReportPage.jsx
index 4a4a9a9a38..73355b17f0 100644
--- a/web-ui/src/pages/PulseReportPage.jsx
+++ b/web-ui/src/pages/PulseReportPage.jsx
@@ -197,7 +197,9 @@ const PulseReportPage = () => {
       }
 
       frequencies[internalScore - 1].internal++;
-      frequencies[externalScore - 1].external++;
+      if (externalScore != null) {
+        frequencies[externalScore - 1].external++;
+      }
 
       let memberIdToUse;
       if (memberId) {
@@ -256,7 +258,9 @@ const PulseReportPage = () => {
     ];
     for(let day of scoreChartDataPoints) {
       day.datapoints.forEach(datapoint => {
-        externalPieCounts[datapoint.externalScore - 1].value++;
+        if (datapoint.externalScore != null) {
+          externalPieCounts[datapoint.externalScore - 1].value++;
+        }
       });
     }
     // Filter out data with a zero value so that the pie chart does not attempt

From a71b1a1096cfd03c7917d2732ba4c013e43bd35e Mon Sep 17 00:00:00 2001
From: Chad Elliott <elliottc@objectcomputing.com>
Date: Thu, 9 Jan 2025 14:47:21 -0600
Subject: [PATCH 10/10] Mark externalScore nullable so that we can pull
 responses with null values in the pulse report.

---
 .../checkins/services/pulseresponse/PulseResponse.java          | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponse.java b/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponse.java
index 1b59be5c40..e77145fd4d 100644
--- a/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponse.java
+++ b/server/src/main/java/com/objectcomputing/checkins/services/pulseresponse/PulseResponse.java
@@ -77,7 +77,7 @@ public class PulseResponse {
     protected PulseResponse() {
     }
 
-    public PulseResponse(UUID id, Integer internalScore, Integer externalScore, LocalDate submissionDate, @Nullable UUID teamMemberId, String internalFeelings, String externalFeelings) {
+    public PulseResponse(UUID id, Integer internalScore, @Nullable Integer externalScore, LocalDate submissionDate, @Nullable UUID teamMemberId, String internalFeelings, String externalFeelings) {
         this.id = id;
         this.internalScore = internalScore;
         this.externalScore = externalScore;