Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Are environment variables for cargo inherited? #443

Closed
thomaseizinger opened this issue Apr 27, 2023 · 2 comments
Closed

Are environment variables for cargo inherited? #443

thomaseizinger opened this issue Apr 27, 2023 · 2 comments

Comments

@thomaseizinger
Copy link
Contributor

thomaseizinger commented Apr 27, 2023

We've recently moved from GitHub's runners to self-hosted runners and are experiencing timeouts when cargo semver-checks tries to update the registry index. For example: https://github.com/libp2p/rust-libp2p/actions/runs/4819569817/jobs/8582952664

We already use the sparse registry protocol but I am wondering whether that also applies for the cargo invocations made by cargo semver-checks?

@obi1kenobi
Copy link
Owner

I think they should be inherited (I've seen the color=always env var setting affect inner cargo invocations) but I don't think we have a test for it.

I'd happily merge a PR adding that kind of test into the test suite if you suspect this might be broken, though.

@thomaseizinger
Copy link
Contributor Author

It was more of a question and we recently haven't seen these errors any more.

Will reopen if it is a problem again!

@thomaseizinger thomaseizinger closed this as not planned Won't fix, can't repro, duplicate, stale May 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants