From 965bb7b7cd244822e353795195c7d3f22c50fac1 Mon Sep 17 00:00:00 2001 From: delambo Date: Thu, 10 Aug 2017 14:28:18 -0400 Subject: [PATCH 1/2] adds lint restriction for server imports --- .../lintScript-server-import/package.json | 5 ++ .../src/client/index.js | 1 + .../src/server/index.js | 0 e2e_tests/tests/kyt-lintScript.test.js | 6 +++ packages/eslint-config-kyt/eslintrc.json | 54 +++++++++++-------- packages/kyt-core/cli/actions/lintScript.js | 40 ++++++-------- packages/kyt-core/yarn.lock | 28 +++++----- .../kyt-starter-static/starter-src/yarn.lock | 34 ++++++------ .../starter-src/src/server/.eslintrc.js | 9 ++++ .../starter-src/yarn.lock | 32 +++++------ 10 files changed, 114 insertions(+), 95 deletions(-) create mode 100644 e2e_tests/fixtures/lintScript-server-import/package.json create mode 100644 e2e_tests/fixtures/lintScript-server-import/src/client/index.js create mode 100644 e2e_tests/fixtures/lintScript-server-import/src/server/index.js create mode 100644 packages/kyt-starter-universal/starter-src/src/server/.eslintrc.js diff --git a/e2e_tests/fixtures/lintScript-server-import/package.json b/e2e_tests/fixtures/lintScript-server-import/package.json new file mode 100644 index 000000000..e9768d3e7 --- /dev/null +++ b/e2e_tests/fixtures/lintScript-server-import/package.json @@ -0,0 +1,5 @@ +{ + "scripts": { + "lint-script": "kyt lint-script" + } +} diff --git a/e2e_tests/fixtures/lintScript-server-import/src/client/index.js b/e2e_tests/fixtures/lintScript-server-import/src/client/index.js new file mode 100644 index 000000000..375052395 --- /dev/null +++ b/e2e_tests/fixtures/lintScript-server-import/src/client/index.js @@ -0,0 +1 @@ +import '../server'; diff --git a/e2e_tests/fixtures/lintScript-server-import/src/server/index.js b/e2e_tests/fixtures/lintScript-server-import/src/server/index.js new file mode 100644 index 000000000..e69de29bb diff --git a/e2e_tests/tests/kyt-lintScript.test.js b/e2e_tests/tests/kyt-lintScript.test.js index ae2f01e56..ae3e03a26 100644 --- a/e2e_tests/tests/kyt-lintScript.test.js +++ b/e2e_tests/tests/kyt-lintScript.test.js @@ -51,6 +51,12 @@ describe('kyt lint-script', () => { expect(output.code).toBe(1); }); + it('should restrict imports from server', () => { + util.setupStageWithFixture(stageName, 'lintScript-server-import'); + const output = shell.exec('npm run lint-script'); + expect(output.code).toBe(1); + }); + afterEach(() => { util.teardownStage(stageName); }); diff --git a/packages/eslint-config-kyt/eslintrc.json b/packages/eslint-config-kyt/eslintrc.json index 5151a0838..531ecf955 100644 --- a/packages/eslint-config-kyt/eslintrc.json +++ b/packages/eslint-config-kyt/eslintrc.json @@ -1,19 +1,12 @@ { - "extends": [ - "airbnb", - "prettier", - "prettier/react" - ], + "extends": ["airbnb", "prettier", "prettier/react"], "env": { "jest": true, "browser": true }, - "plugins": [ - "json", - "prettier" - ], + "plugins": ["json", "prettier"], "parser": "babel-eslint", "parserOptions": { @@ -32,25 +25,40 @@ "constructor-super": 2, "no-this-before-super": 2, "prefer-spread": 2, - "no-warning-comments": [1, { "terms": ["todo", "fixme"], "location": "start" }], + "no-warning-comments": [ + 1, + { "terms": ["todo", "fixme"], "location": "start" } + ], "react/sort-comp": 0, "react/jsx-filename-extension": [1, { "extensions": [".js", ".jsx"] }], "import/extensions": [1, { "js": "never" }], "react/require-extension": "off", "import/no-extraneous-dependencies": [0], "no-param-reassign": 0, - "comma-dangle": ["error", { - "arrays": "always-multiline", - "objects": "always-multiline", - "imports": "always-multiline", - "exports": "always-multiline", - "functions": "never" - }], - "prettier/prettier": ["error", { - "printWidth": 100, - "semi": true, - "singleQuote": true, - "trailingComma": "es5" - }] + "comma-dangle": [ + "error", + { + "arrays": "always-multiline", + "objects": "always-multiline", + "imports": "always-multiline", + "exports": "always-multiline", + "functions": "never" + } + ], + "import/no-restricted-paths": [ + "error", + { + "zones": [{ "target": "./src", "from": "./src/server" }] + } + ], + "prettier/prettier": [ + "error", + { + "printWidth": 100, + "semi": true, + "singleQuote": true, + "trailingComma": "es5" + } + ] } } diff --git a/packages/kyt-core/cli/actions/lintScript.js b/packages/kyt-core/cli/actions/lintScript.js index e15229d05..a8c215d53 100644 --- a/packages/kyt-core/cli/actions/lintScript.js +++ b/packages/kyt-core/cli/actions/lintScript.js @@ -7,31 +7,25 @@ const glob = require('glob'); const { userRootPath } = require('kyt-utils/paths')(); module.exports = (config, flags) => { + shell.config.silent = false; const eslintrc = glob.sync(`${userRootPath}/.*eslintrc*`); - const configFile = eslintrc.length - ? eslintrc[0] - : path.join(__dirname, '../../config/.eslintrc.base.json'); + const backupFile = path.join(__dirname, '../../config/.eslintrc.base.json'); + const configFile = eslintrc.length ? '' : `-c ${backupFile}`; + const eslintLib = require.resolve('eslint'); + const eslint = eslintLib.replace(/(.*)(lib\/api\.js)/, '$1bin/eslint.js'); + const sources = 'src/ kyt.config.js package.json'; + const userFlags = `${flags.join(' ')}`; + const extensions = '--ext .js --ext .json'; - logger.info(`Using ESLint file: ${configFile}`); + logger.info(`Using ESLint file: ${eslintrc.length ? eslintrc[0] : backupFile}`); - const lint = () => { - shell.config.silent = false; - const eslintLib = require.resolve('eslint'); - const eslint = eslintLib.replace(/(.*)(lib\/api\.js)/, '$1bin/eslint.js'); - const sources = 'src/ kyt.config.js package.json'; - const userFlags = `${flags.join(' ')}`; - const extensions = '--ext .js --ext .json'; + const cmd = `${eslint} ${sources} ${configFile} --color ${userFlags} ${extensions}`; + const output = shell.exec(cmd); + if (output.code === 0) { + logger.end( + `Your JS looks ${output.stdout === '' ? 'great ✨' : 'OK, though there were warnings 🤔👆'}` + ); + } - const cmd = `${eslint} ${sources} -c ${configFile} --color ${userFlags} ${extensions}`; - const output = shell.exec(cmd); - if (output.code === 0) { - logger.end( - `Your JS looks ${output.stdout === '' ? 'great ✨' : 'OK, though there were warnings 🤔👆'}` - ); - } - - process.exit(output.code > 0 ? 1 : 0); - }; - - lint(); + process.exit(output.code > 0 ? 1 : 0); }; diff --git a/packages/kyt-core/yarn.lock b/packages/kyt-core/yarn.lock index 84acdadda..961fe6f03 100644 --- a/packages/kyt-core/yarn.lock +++ b/packages/kyt-core/yarn.lock @@ -1050,10 +1050,10 @@ browserslist@^1.1.1, browserslist@^1.1.3, browserslist@^1.3.6, browserslist@^1.5 electron-to-chromium "^1.2.7" browserslist@^2.1.3: - version "2.3.0" - resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-2.3.0.tgz#b2aa76415c71643fe2368f6243b43bbbb4211752" + version "2.3.1" + resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-2.3.1.tgz#39500a2090330b2a090120ea6c7fc78b6e091c5e" dependencies: - caniuse-lite "^1.0.30000710" + caniuse-lite "^1.0.30000712" electron-to-chromium "^1.3.17" bser@1.0.2: @@ -1151,12 +1151,12 @@ caniuse-api@^1.5.2: lodash.uniq "^4.5.0" caniuse-db@^1.0.30000187, caniuse-db@^1.0.30000529, caniuse-db@^1.0.30000634, caniuse-db@^1.0.30000639: - version "1.0.30000712" - resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000712.tgz#89748396f9d7419d5fa27df3b48872dadbf8318a" + version "1.0.30000713" + resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000713.tgz#ea01761840b5f148faf94ec5f34d0aa1d321966f" -caniuse-lite@^1.0.30000670, caniuse-lite@^1.0.30000710: - version "1.0.30000712" - resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30000712.tgz#b4732def2459224f3f78c6a9ba103abfcc705670" +caniuse-lite@^1.0.30000670, caniuse-lite@^1.0.30000712: + version "1.0.30000713" + resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30000713.tgz#33957ecb4a2154a5d40a60d13d8bf1cfa0881a8a" caseless@~0.12.0: version "0.12.0" @@ -1919,8 +1919,8 @@ ee-first@1.1.1: resolved "https://registry.yarnpkg.com/ee-first/-/ee-first-1.1.1.tgz#590c61156b0ae2f4f0255732a158b266bc56b21d" electron-to-chromium@^1.2.7, electron-to-chromium@^1.3.17: - version "1.3.17" - resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.17.tgz#41c13457cc7166c5c15e767ae61d86a8cacdee5d" + version "1.3.18" + resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.18.tgz#3dcc99da3e6b665f6abbc71c28ad51a2cd731a9c" elliptic@^6.0.0: version "6.4.0" @@ -5332,8 +5332,8 @@ rc@^1.0.1, rc@^1.1.7: strip-json-comments "~2.0.1" react-deep-force-update@^2.0.1: - version "2.0.1" - resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-2.0.1.tgz#4f7f6c12c3e7de42f345992a3c518236fa1ecad3" + version "2.1.0" + resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-2.1.0.tgz#1c5f36ea96bcbf411605ec063f36c568ea4df86c" react-hot-loader@3.0.0-beta.6: version "3.0.0-beta.6" @@ -5764,8 +5764,8 @@ select-hose@^2.0.0: resolved "https://registry.yarnpkg.com/select-hose/-/select-hose-2.0.0.tgz#625d8658f865af43ec962bfc376a37359a4994ca" selfsigned@^1.9.1: - version "1.9.1" - resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-1.9.1.tgz#cdda4492d70d486570f87c65546023558e1dfa5a" + version "1.10.1" + resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-1.10.1.tgz#bf8cb7b83256c4551e31347c6311778db99eec52" dependencies: node-forge "0.6.33" diff --git a/packages/kyt-starter-static/starter-src/yarn.lock b/packages/kyt-starter-static/starter-src/yarn.lock index 44498ec54..694ba69fa 100644 --- a/packages/kyt-starter-static/starter-src/yarn.lock +++ b/packages/kyt-starter-static/starter-src/yarn.lock @@ -1162,10 +1162,10 @@ browserslist@^1.1.1, browserslist@^1.1.3, browserslist@^1.3.6, browserslist@^1.5 electron-to-chromium "^1.2.7" browserslist@^2.1.3: - version "2.3.0" - resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-2.3.0.tgz#b2aa76415c71643fe2368f6243b43bbbb4211752" + version "2.3.1" + resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-2.3.1.tgz#39500a2090330b2a090120ea6c7fc78b6e091c5e" dependencies: - caniuse-lite "^1.0.30000710" + caniuse-lite "^1.0.30000712" electron-to-chromium "^1.3.17" bser@1.0.2: @@ -1270,12 +1270,12 @@ caniuse-api@^1.5.2: lodash.uniq "^4.5.0" caniuse-db@^1.0.30000187, caniuse-db@^1.0.30000529, caniuse-db@^1.0.30000634, caniuse-db@^1.0.30000639: - version "1.0.30000712" - resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000712.tgz#89748396f9d7419d5fa27df3b48872dadbf8318a" + version "1.0.30000713" + resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000713.tgz#ea01761840b5f148faf94ec5f34d0aa1d321966f" -caniuse-lite@^1.0.30000670, caniuse-lite@^1.0.30000710: - version "1.0.30000712" - resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30000712.tgz#b4732def2459224f3f78c6a9ba103abfcc705670" +caniuse-lite@^1.0.30000670, caniuse-lite@^1.0.30000712: + version "1.0.30000713" + resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30000713.tgz#33957ecb4a2154a5d40a60d13d8bf1cfa0881a8a" caseless@~0.12.0: version "0.12.0" @@ -2055,11 +2055,7 @@ domain-browser@^1.1.1: version "1.1.7" resolved "https://registry.yarnpkg.com/domain-browser/-/domain-browser-1.1.7.tgz#867aa4b093faa05f1de08c06f4d7b21fdf8698bc" -domelementtype@1: - version "1.3.0" - resolved "https://registry.yarnpkg.com/domelementtype/-/domelementtype-1.3.0.tgz#b17aed82e8ab59e52dd9c19b1756e0fc187204c2" - -domelementtype@~1.1.1: +domelementtype@1, domelementtype@~1.1.1: version "1.1.3" resolved "https://registry.yarnpkg.com/domelementtype/-/domelementtype-1.1.3.tgz#bd28773e2642881aec51544924299c5cd822185b" @@ -2124,8 +2120,8 @@ ee-first@1.1.1: resolved "https://registry.yarnpkg.com/ee-first/-/ee-first-1.1.1.tgz#590c61156b0ae2f4f0255732a158b266bc56b21d" electron-to-chromium@^1.2.7, electron-to-chromium@^1.3.17: - version "1.3.17" - resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.17.tgz#41c13457cc7166c5c15e767ae61d86a8cacdee5d" + version "1.3.18" + resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.18.tgz#3dcc99da3e6b665f6abbc71c28ad51a2cd731a9c" elliptic@^6.0.0: version "6.4.0" @@ -5801,8 +5797,8 @@ react-addons-test-utils@15.3.0: resolved "https://registry.yarnpkg.com/react-addons-test-utils/-/react-addons-test-utils-15.3.0.tgz#06d7affdbb729a48ebe0e27966d0cd0e82b57298" react-deep-force-update@^2.0.1: - version "2.0.1" - resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-2.0.1.tgz#4f7f6c12c3e7de42f345992a3c518236fa1ecad3" + version "2.1.0" + resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-2.1.0.tgz#1c5f36ea96bcbf411605ec063f36c568ea4df86c" react-dom@15.3.0: version "15.3.0" @@ -6269,8 +6265,8 @@ select-hose@^2.0.0: resolved "https://registry.yarnpkg.com/select-hose/-/select-hose-2.0.0.tgz#625d8658f865af43ec962bfc376a37359a4994ca" selfsigned@^1.9.1: - version "1.9.1" - resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-1.9.1.tgz#cdda4492d70d486570f87c65546023558e1dfa5a" + version "1.10.1" + resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-1.10.1.tgz#bf8cb7b83256c4551e31347c6311778db99eec52" dependencies: node-forge "0.6.33" diff --git a/packages/kyt-starter-universal/starter-src/src/server/.eslintrc.js b/packages/kyt-starter-universal/starter-src/src/server/.eslintrc.js new file mode 100644 index 000000000..b66a930c6 --- /dev/null +++ b/packages/kyt-starter-universal/starter-src/src/server/.eslintrc.js @@ -0,0 +1,9 @@ +// +// Disable the eslint-config-kyt `import/no-restricted-paths` rule. +// It's initially set to restrict all imports from `src/server`. +// +module.exports = { + rules: { + "import/no-restricted-paths": "off", + }, +}; diff --git a/packages/kyt-starter-universal/starter-src/yarn.lock b/packages/kyt-starter-universal/starter-src/yarn.lock index 31838f7c6..6a55e697c 100644 --- a/packages/kyt-starter-universal/starter-src/yarn.lock +++ b/packages/kyt-starter-universal/starter-src/yarn.lock @@ -1154,10 +1154,10 @@ browserslist@^1.1.1, browserslist@^1.1.3, browserslist@^1.3.6, browserslist@^1.5 electron-to-chromium "^1.2.7" browserslist@^2.1.3: - version "2.3.0" - resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-2.3.0.tgz#b2aa76415c71643fe2368f6243b43bbbb4211752" + version "2.3.1" + resolved "https://registry.yarnpkg.com/browserslist/-/browserslist-2.3.1.tgz#39500a2090330b2a090120ea6c7fc78b6e091c5e" dependencies: - caniuse-lite "^1.0.30000710" + caniuse-lite "^1.0.30000712" electron-to-chromium "^1.3.17" bser@1.0.2: @@ -1255,12 +1255,12 @@ caniuse-api@^1.5.2: lodash.uniq "^4.5.0" caniuse-db@^1.0.30000187, caniuse-db@^1.0.30000529, caniuse-db@^1.0.30000634, caniuse-db@^1.0.30000639: - version "1.0.30000712" - resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000712.tgz#89748396f9d7419d5fa27df3b48872dadbf8318a" + version "1.0.30000713" + resolved "https://registry.yarnpkg.com/caniuse-db/-/caniuse-db-1.0.30000713.tgz#ea01761840b5f148faf94ec5f34d0aa1d321966f" -caniuse-lite@^1.0.30000670, caniuse-lite@^1.0.30000710: - version "1.0.30000712" - resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30000712.tgz#b4732def2459224f3f78c6a9ba103abfcc705670" +caniuse-lite@^1.0.30000670, caniuse-lite@^1.0.30000712: + version "1.0.30000713" + resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30000713.tgz#33957ecb4a2154a5d40a60d13d8bf1cfa0881a8a" caseless@~0.12.0: version "0.12.0" @@ -1810,13 +1810,13 @@ date-now@^0.1.4: version "0.1.4" resolved "https://registry.yarnpkg.com/date-now/-/date-now-0.1.4.tgz#eaf439fd4d4848ad74e5cc7dbef200672b9e345b" -debug@2.6.7: +debug@2.6.7, debug@^2.1.1: version "2.6.7" resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.7.tgz#92bad1f6d05bbb6bba22cca88bcd0ec894c2861e" dependencies: ms "2.0.0" -debug@2.6.8, debug@^2.1.1, debug@^2.2.0, debug@^2.6.3, debug@^2.6.8: +debug@2.6.8, debug@^2.2.0, debug@^2.6.3, debug@^2.6.8: version "2.6.8" resolved "https://registry.yarnpkg.com/debug/-/debug-2.6.8.tgz#e731531ca2ede27d188222427da17821d68ff4fc" dependencies: @@ -2049,8 +2049,8 @@ ee-first@1.1.1: resolved "https://registry.yarnpkg.com/ee-first/-/ee-first-1.1.1.tgz#590c61156b0ae2f4f0255732a158b266bc56b21d" electron-to-chromium@^1.2.7, electron-to-chromium@^1.3.17: - version "1.3.17" - resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.17.tgz#41c13457cc7166c5c15e767ae61d86a8cacdee5d" + version "1.3.18" + resolved "https://registry.yarnpkg.com/electron-to-chromium/-/electron-to-chromium-1.3.18.tgz#3dcc99da3e6b665f6abbc71c28ad51a2cd731a9c" elliptic@^6.0.0: version "6.4.0" @@ -5618,8 +5618,8 @@ react-addons-test-utils@15.3.0: resolved "https://registry.yarnpkg.com/react-addons-test-utils/-/react-addons-test-utils-15.3.0.tgz#06d7affdbb729a48ebe0e27966d0cd0e82b57298" react-deep-force-update@^2.0.1: - version "2.0.1" - resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-2.0.1.tgz#4f7f6c12c3e7de42f345992a3c518236fa1ecad3" + version "2.1.0" + resolved "https://registry.yarnpkg.com/react-deep-force-update/-/react-deep-force-update-2.1.0.tgz#1c5f36ea96bcbf411605ec063f36c568ea4df86c" react-dom@15.3.0: version "15.3.0" @@ -6072,8 +6072,8 @@ select-hose@^2.0.0: resolved "https://registry.yarnpkg.com/select-hose/-/select-hose-2.0.0.tgz#625d8658f865af43ec962bfc376a37359a4994ca" selfsigned@^1.9.1: - version "1.9.1" - resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-1.9.1.tgz#cdda4492d70d486570f87c65546023558e1dfa5a" + version "1.10.1" + resolved "https://registry.yarnpkg.com/selfsigned/-/selfsigned-1.10.1.tgz#bf8cb7b83256c4551e31347c6311778db99eec52" dependencies: node-forge "0.6.33" From 33bc7770303d066cc533c7bbb24b9abdacd2642f Mon Sep 17 00:00:00 2001 From: delambo Date: Thu, 10 Aug 2017 21:05:42 -0400 Subject: [PATCH 2/2] publishes --- CHANGELOG.md | 4 ++++ packages/eslint-config-kyt/README.md | 4 ++++ packages/eslint-config-kyt/package.json | 9 ++------- packages/kyt-core/package.json | 10 +++------- packages/kyt-starter-static/package.json | 2 +- packages/kyt-starter-static/starter-src/package.json | 2 +- packages/kyt-starter-universal/package.json | 2 +- .../kyt-starter-universal/starter-src/package.json | 2 +- 8 files changed, 17 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 01d9a4f14..d69d5f751 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,10 @@ ## Master +## 0.9.0-alpha.3 08/10/17 + +- Adds lint rule that restricts server imports. See more in [eslint-config-kyt 0.5.0 changelog](/packages/eslint-config-kyt/README.md#changelog). + ## 0.9.0-alpha.2 08/08/17 - Fixes assets manifest merging by only merging server public assets diff --git a/packages/eslint-config-kyt/README.md b/packages/eslint-config-kyt/README.md index dd1e47c76..835827e56 100644 --- a/packages/eslint-config-kyt/README.md +++ b/packages/eslint-config-kyt/README.md @@ -63,6 +63,10 @@ To keep things formatted as you develop, install an editor package. See more [he ## Changelog +**0.5.0-alpha.1 - 08/10/17 + +- Adds rule to restrict server imports. If you have a `src/server` directory, you will need to add this [.eslintrc.js](https://github.com/NYTimes/kyt/blob/965bb7b7cd244822e353795195c7d3f22c50fac1/packages/kyt-starter-universal/starter-src/src/server/.eslintrc.js) into the root of the server directory. This may be a breaking change if you have any server imports in your project from outside of the `src/server` directory. + **0.4.0 - 07/07/17 ### BREAKING CHANGES diff --git a/packages/eslint-config-kyt/package.json b/packages/eslint-config-kyt/package.json index 56657e8e2..68f6f08b7 100644 --- a/packages/eslint-config-kyt/package.json +++ b/packages/eslint-config-kyt/package.json @@ -1,6 +1,6 @@ { "name": "eslint-config-kyt", - "version": "0.4.0", + "version": "0.5.0-alpha.1", "description": "ESLint configuration for kyt projects.", "main": "eslintrc.json", "author": "NYTimes", @@ -20,10 +20,5 @@ "prettier": "1.5.2", "prettier-eslint-cli": "4.1.1" }, - "keywords": [ - "kyt", - "eslint", - "config", - "eslint-config" - ] + "keywords": ["kyt", "eslint", "config", "eslint-config"] } diff --git a/packages/kyt-core/package.json b/packages/kyt-core/package.json index fcc434454..7da55dbc8 100644 --- a/packages/kyt-core/package.json +++ b/packages/kyt-core/package.json @@ -1,6 +1,6 @@ { "name": "kyt", - "version": "0.9.0-alpha.2", + "version": "0.9.0-alpha.3", "description": "kyt is a toolkit that encapsulates and manages the configuration for web apps.", "author": "NYTimes", "license": "Apache-2.0", @@ -30,7 +30,7 @@ "detect-port": "1.0.1", "eslint": "3.19.0", "eslint-config-airbnb": "15.0.2", - "eslint-config-kyt": "0.4.0", + "eslint-config-kyt": "0.5.0-alpha.1", "eslint-config-prettier": "2.3.0", "eslint-plugin-import": "2.7.0", "eslint-plugin-json": "1.2.0", @@ -77,9 +77,5 @@ "webpack-merge": "4.1.0", "webpack-node-externals": "1.6.0" }, - "keywords": [ - "kyt", - "core", - "kyt-core" - ] + "keywords": ["kyt", "core", "kyt-core"] } diff --git a/packages/kyt-starter-static/package.json b/packages/kyt-starter-static/package.json index 1b90eba75..ad07f65b6 100644 --- a/packages/kyt-starter-static/package.json +++ b/packages/kyt-starter-static/package.json @@ -1,6 +1,6 @@ { "name": "kyt-starter-static", - "version": "0.6.0-alpha.2", + "version": "0.6.0-alpha.3", "description": "", "repository": { "type": "git", diff --git a/packages/kyt-starter-static/starter-src/package.json b/packages/kyt-starter-static/starter-src/package.json index 762208f4f..42f3fd50f 100644 --- a/packages/kyt-starter-static/starter-src/package.json +++ b/packages/kyt-starter-static/starter-src/package.json @@ -22,7 +22,7 @@ }, "devDependencies": { "enzyme": "2.4.1", - "kyt": "0.9.0-alpha.2", + "kyt": "0.9.0-alpha.3", "react-addons-test-utils": "15.3.0" } } diff --git a/packages/kyt-starter-universal/package.json b/packages/kyt-starter-universal/package.json index 90b21bd40..de1dcaeea 100644 --- a/packages/kyt-starter-universal/package.json +++ b/packages/kyt-starter-universal/package.json @@ -1,6 +1,6 @@ { "name": "kyt-starter-universal", - "version": "0.6.0-alpha.2", + "version": "0.6.0-alpha.3", "description": "", "repository": { "type": "git", diff --git a/packages/kyt-starter-universal/starter-src/package.json b/packages/kyt-starter-universal/starter-src/package.json index 4a9648cd1..f586b4f84 100644 --- a/packages/kyt-starter-universal/starter-src/package.json +++ b/packages/kyt-starter-universal/starter-src/package.json @@ -23,7 +23,7 @@ }, "devDependencies": { "enzyme": "2.4.1", - "kyt": "0.9.0-alpha.2", + "kyt": "0.9.0-alpha.3", "react-addons-test-utils": "15.3.0" } }