-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: path.join is lowercasing the drive letter #2466
Comments
That's actually not an issue with Node-Webkit per se. You can find the Node.js references here Specifically the code exporting the normalize function in exports.normalize
and in exports.join (i.e. path.join) normalize is called:
So by default, the drive letter is lower cased by default by Node.Js standards. |
Yeah I assumed it was probably something Node had changed. Do you know which version changed this? |
Here's the revision page and I believe that was released in version v0.10.25 of NodeJs on January 23 |
Node issue: nodejs/node-v0.x-archive#7031 |
Works fine on nwjs-sdk-v0.26.3, please try the latest nwjs build. |
Optimistically closing 😄 |
To reproduce:
Run
nw.exe
from 0.10.5Paste this in the dev tools console:
Expected:
C:\........\Ab
Actual:
c:\....\Ab
Happens with 0.10.5 but not 0.8.6. Tested on Windows 7 and 8.
Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
The text was updated successfully, but these errors were encountered: