Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CommandPalette] Generics not working well with items inside groups #2260

Open
benjamincanac opened this issue Sep 26, 2024 — with Volta.net · 2 comments
Open

[CommandPalette] Generics not working well with items inside groups #2260

benjamincanac opened this issue Sep 26, 2024 — with Volta.net · 2 comments
Labels
bug Something isn't working typescript v3 #1289

Comments

Copy link
Member

@benjamincanac benjamincanac added bug Something isn't working v3 #1289 labels Sep 26, 2024 — with Volta.net
@benjamincanac
Copy link
Member Author

@yassilah Given the awesome work you did on generic types, would you have an idea on how to solve this as well?

@yassilah
Copy link
Contributor

yassilah commented Oct 28, 2024

I added the item type inference but actually TS would still throw an error here because not all items have the 'id' prop, so you'd need to wrap it inside a v-if like here:

https://play.vuejs.org/#eNqdVm1v2zYQ/itXbYATwC/Y2n3RHAfL1gVZgS5IDPRDFCCqdI7ZyKRAUo6N1P+9d6RlUY5f2n4IQh4f3j139/Dkl+ivsuzPK4ziaGgyLUoLBm1VjhIpZqXSFv5Ws1kq8+u0QGsRJlrNoNMftM3sovNnIjMljYVHrarSwBncvSQSQOQxdMirFfLRdLrOZHFmYrjjNcALFOlnLAh1rdVEFNjpgiBXZBC9KWrFG9OrDOoOrJyD8NKFKApyvftSpjEXtpelOt9196OyYiKy1AoC7/ZAwGLX1VvMKi3scvetQmVPvaxQBjku371P5KoLTUU4nT3l4PPfuptI/1T6mfjDDS6lKnITsmHo7w30A0qrJIzVs8Rt2NsGNiaiaBA+VdJk023guwZ4gZLql1n4gMYU7foz9I8gdGqxWEq4UdNUBjnT33DgtUWqog0lWxYEph3AcEtfsRfPWRL5RRI5GAHra/ALl6tXYJpT1wlITMhAAWtoCJ73xIQwHUFtENIhAxyl4W/3RQ4rR9ldH7Q4vjIMt+RPxhYi6kbWkAwm4rH/xShJr8v1PYkyNStJ4Pr/0ikuiWKvCD5Li0I9/+dsVle4rjPdmWL2tMP+xSzYlkTX3Es9xyTanNlUP6L1x+9vP+KC1pvDmcqrgtAHDm/QqKJijh52UcmcaAc4x/bKzQhqw9i8X1iUpk6KiTLSqyWJaD5Qyfam3tB923/n7pFwqIqvp0wwqIrUtd96jeDCjSshLepJmuHW4Lpiibh4Tq/nMRiriThbTKFsYKDYR91dsjibx9z4OuIdNs+dTK8Z3vGD4fB2WSKw5V+aty7Y8BKoUShzs4vKiKZtA/CapolyIuQENVyd3t3DCs7hCmKQOKdGHk+RZnFphpcjn6V/jUT6ss3xlrLzyDFzOCl5TZ11DGIY03CUOS4obDX7TFRWp3A2glQuAwbOUTs4uyWXQUbtMq44mCPWoWdHQ7gJbDDV2XSMehbAT2Mfk/BuKAf4SrizFobJd+JWcht7PXn2n7ME9p5anQr3udoGuJq2J2X4RQ7lDo80lrXIaHtQFe5h+G+yS5dqluNEyHVvd/d7dHJaX+KaN5d8T3b1aUuoI+/j0NTPxbwerbSkKT1RmrI5cTLrerVdsXBOeWrXnwKIn3BJsAdn6P360uBWD+H4b/nksq9l2Hjruxdy2CXt3K2Wb/LOZYFYpjOki+7r4Sxfv65d1zsvI47BizXWbdkr7/l/y/d+7+fwQHTq7apW4QO96CCqQzX7FuwhVC+ldIwWDFznQmplKusvqqPipM6pvnnjtHJ3gC9Dj7KtQWuubnu/VaEfqNFPx/zBpoW/JHxNmh8T9U8Kjtbu9IDr+arG35daPUaOZRfifIIby3cqYE8Gw0HwhjfretX+ObT6Bg5/Ju0=

The other option is to turn the items into an intersection and then you wouldn't need to wrap it like here:
https://play.vuejs.org/#eNqdVm1v2zYQ/itXbYBtwC/Y2n3RHAfL1gVegS5IHPRDFCCqdE7YyKRAUk6M1P+9d5QlUY5f2n4IQh6fu3vuuSPll+CvPB8uCwzCYGwSLXILBm2RTyIpFrnSFv5Wi0Us04s4Q2sR5lotoDMctc0covNnJBMljYV7rYrcwAncvEQSQKQhdCiqFfLedPrOZHFhQrjhNcALZPFnzAh1odVcZNjpg6BQZBCDB9SKN2ZQGNQdWLsAvtOZyDIKvdsp0ZgKO0hine7y/aismIsktoLAuyMQMNvleoVJoYVd7fbKVPI4SDJlkPOy720k131oFOFy9sjB57/160z/FPqJ+MMlrqTKUuOzYejvDfQDSqskzNSTxG3Y2wY2I6JoED4V0iQP28B3DfAMJemXWPiAxmRt/Rn6h5c6tpitJFyqh1h6NdPfeFTOFk0VbajYPCMw7QDGW/MVlsNzEgXlIgocjICVG/zCcg0yjFPqOgGJCRkoYQUlcqVtKFJYOyLkP2rn3ZpgMrYQQT+whjo5F/fDL0ZJuiCudVGQqEVOM6r/z93QREFYNpXP4ixTT/85m9UFbqQinwdMHnfYv5hntkXBBbdDLzEK6jMb63u05fH7q4/4TOv6cKHSIiP0gcNLNCormGMJOytkSrQ9nGM7ddeclJyZ988WpamKYqKMLBseBXTFSbK9pTd03w7fOT/qPan4+qHw3posdh20ZZvx2b04QlrU8zjBrbdnyl12+dzInYZgrCbibDGZsp6Bch8Nd87z1dzHJtaR6FDfWDK9ZnjDMx9Ju8oRriXJNFNTZmAwYdHG1xN6GLvXQC1DmRqI5QpOofsYwnUPTiawVDS0IUhcou7VqC4DhJyjhmkN65HjtMJyxS4pk/iXXmlX3/i8DrGjeqayi2PjVN4jepu6VfKbW1j7ed2dPiI1Peu5GZ9PSrXLi03inW+02hC/IpVL5MxplPOaJsxRCGFG76xM8ZnyFovPxGXthCD9PAYuUDs5h6WQXkntdq45mSPWoetP73mT2GCsk4cZ6oUH74VlTsK7993DF8KdtTBMvhO2iqvt1SO2/5xHce+p1bFwX75tgNO0/ej6H3f/2sE9vfBaJLQ9OCrugpafd1cuaZbiXMhNb3f3e9LtVU6seeNU9mRXn7amd1LGOPQBScWy+kTQEpaDudJUTdeNWb+ctikPTo/mZzN8VHf4iCuC3TnD4NeXBre+874k7Zgs+2YMm2hDd0UOh6Sd82rFpugsC4QyXiA5uk+Ws3z9ugld7cox4hy82GDdlqPynv+3Yu+Pfgp3RKfarqspvKMr7WV1qGbfgt3500slHaMFI9c5n1oeS9JVzCtmbtS51Ddv3KzcHODL0KNsK9CGq9vebin0Axr9dM4fbJr/86XUpPoFU1MecbZ2p0es5yuNv6+06hk5Vp2PKwusLd85AXsqGI+8O1yvq1X7Z9n6G79OQhI=

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working typescript v3 #1289
Projects
None yet
2 participants