Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dev): restart nuxt if unhandled rejection occurs #602

Merged
merged 3 commits into from
Dec 18, 2024

Conversation

danielroe
Copy link
Member

@danielroe danielroe commented Dec 18, 2024

πŸ”— Linked issue

❓ Type of change

  • πŸ“– Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

investigating nuxt/nuxt#30137 (comment), every time I started Nuxt, a zombie process would be left behind due to an unhandled rejection.

this adds handling to kill + restart nuxt, which doesn't address the issue (still investigating - it's about watchers) but at least prevents zombie processes from accumulating

(alternatively, or perhaps in future, we could add an additional signal if we wanted to handle differently - would love ideas @pi0)

@danielroe danielroe requested a review from pi0 December 18, 2024 15:23
@danielroe danielroe self-assigned this Dec 18, 2024
@danielroe danielroe merged commit e0e8e05 into main Dec 18, 2024
3 checks passed
@danielroe danielroe deleted the fix/unhandled-rejections branch December 18, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants