Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using extractCSS causes css links to not be preloaded #278

Closed
gotenxds opened this issue Jan 31, 2020 · 4 comments
Closed

Using extractCSS causes css links to not be preloaded #278

gotenxds opened this issue Jan 31, 2020 · 4 comments

Comments

@gotenxds
Copy link

Module version
The version of the module you're using.
nuxt 2.0.0
nuxt-ts 0.3.8
vuetify 2.0.0-alpha.4

Describe the bug
When enabling extractCSS some of the css gets extracted as expected but for some reason this creates 3 new css files that are not marked as preloaded

image

To Reproduce
Just make a clean nuxt with vutify project and use the extractcss option

Expected behavior
A clear and concise description of what you expected to happen.
all new css files to be marked as preloaded as well.

@kevinmarrec
Copy link
Member

Duplicate of #232

See : #232 (comment)
or directly : https://github.com/kevinmarrec/nuxt-css-issue for some details in README
May also be related : #208

You can eventually comment there so we don't open multiple issues.
Overall this issue is cause of Vuetify components CSS in JS, making components CSS in Nuxt pages (still it still seem to work in layouts) not preloaded correctly

@gotenxds
Copy link
Author

I'm not sure this is a duplicate, #232 talks about how CSS is not included in the response, this issue is about the HTML header link tag is not marked as preload when the extractCss is true, I don't think this has anything to do with SSR

@kevinmarrec
Copy link
Member

kevinmarrec commented Feb 12, 2020

@gotenxds The issue in #232 isn't all about SSR, it's about Critical CSS not preloaded. It affects SSR but is not only related to it.

The good term is that not having these CSS "preloaded" make them not SSR ready, and overall affect performance with SSR, but it's an issue as well in SPA if i'm right. It's about HTML markup not correct in either SSR response if using SSR, or SPA first Html markup loaded at runtime

@nachogarcia
Copy link

I'd say this it's also related to nuxt/nuxt#6980 and it's happening to me without vuetify.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants