-
-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
execute_if_off not on correct place #356
Comments
It’s a color_options is a compound expose with a execure_if_off sub key. So he placement is correct, hitting true/false also sends the right payload. I think just the toggle button is broken. it’s probably going to get rename/more sub keys soon Koenkk/zigbee-herdsman-converters#2284 |
Ah ok, no problem, then there's something wrong with the double line, or? |
I think the double line is correct. Once there are more sub keys they only get added in the right side. looks like there is still a bug showing the toggle icon in between true/false though. Neither refresh buttons seem to work too, just retested, clicking true or false does work as expected. |
sorry @sjorge , if there are more sub keys, imho there still will be a double line ;-) |
For now the expose of color_options will be removed from the converters, as the support is a mixed bag. Koenkk/zigbee-herdsman-converters#2303 Most my bulbs do, but originally I didn't want to expose it, as we don't for level_config, power_on_behavior, ... and this is in the same category. A few people already complained non bulb osram (GU10, lanterns, ...) throws unsupport_attribute so there is now a PR open to remove it. (Not the converters, just the expose) There is however https://github.com/Koenkk/zigbee-herdsman-converters/blob/3e3a06961296b02ea8fdbd3111dd26c69895c08f/lib/exposes.js#L202 which probably suffers the same issues. |
execute_if_off is not on correct place, I mean it looks a little bit weird
The text was updated successfully, but these errors were encountered: